18
0
mirror of https://github.com/MaSzyna-EU07/maszyna.git synced 2026-11-19 05:16:01 +01:00

fix(render): alpha to coverage only where it is on, full coverage on flat alpha

Review of the alpha to coverage change for alpha tested surfaces:

- An alpha which is flat over the pixel (fwidth 0) and equal to the opacity
  threshold got a coverage of 0.5, so e.g. opacity 1 on an opaque or DXT1
  texture turned half see-through with multisampling. Without an alpha edge
  in the pixel the plain test decides now: step(opacity, alpha).
- The shaders took the coverage path whenever they were built with
  multisampling, also where alpha to coverage is off (the reflections pass)
  or does nothing (the single-sampled model previews), and grew the cut-outs
  there by about half a pixel. model_ubo gets an alpha_to_coverage flag, set
  together with the GL state, and the shaders keep the plain alpha test
  without it. The previews no longer turn alpha to coverage on. The flag
  takes 4 of the 12 padding bytes after shadow_tone, so the std140 layout and
  the size of the block stay the same.
- The shader validator never set iMultisampling, so it never compiled the
  alpha to coverage branches. Its "features on" configuration uses the
  default of 2 now, on desktop GL and GLES.
This commit is contained in:
jerrrrycho
2026-11-08 20:03:32 +01:00
parent aecc73e893
commit 04b55c866a
4 changed files with 27 additions and 6 deletions

View File

@@ -46,6 +46,8 @@ bool check_shader_allopts(std::string filename)
Global.gfx_skippipeline = false;
Global.gfx_extraeffects = true;
Global.gfx_shadergamma = true;
// the default of the simulator, which compiles the alpha to coverage branches of the shaders
Global.iMultisampling = 2;
if (!check_shader(filename))
suc = false;
@@ -56,6 +58,7 @@ bool check_shader_allopts(std::string filename)
Global.gfx_skippipeline = true;
Global.gfx_extraeffects = false;
Global.gfx_shadergamma = false;
Global.iMultisampling = 0;
if (!check_shader(filename))
suc = false;