18
0
mirror of https://github.com/MaSzyna-EU07/maszyna.git synced 2026-11-19 02:56:01 +01:00

fix(render): alpha to coverage only where it is on, full coverage on flat alpha

Review of the alpha to coverage change for alpha tested surfaces:

- An alpha which is flat over the pixel (fwidth 0) and equal to the opacity
  threshold got a coverage of 0.5, so e.g. opacity 1 on an opaque or DXT1
  texture turned half see-through with multisampling. Without an alpha edge
  in the pixel the plain test decides now: step(opacity, alpha).
- The shaders took the coverage path whenever they were built with
  multisampling, also where alpha to coverage is off (the reflections pass)
  or does nothing (the single-sampled model previews), and grew the cut-outs
  there by about half a pixel. model_ubo gets an alpha_to_coverage flag, set
  together with the GL state, and the shaders keep the plain alpha test
  without it. The previews no longer turn alpha to coverage on. The flag
  takes 4 of the 12 padding bytes after shadow_tone, so the std140 layout and
  the size of the block stay the same.
- The shader validator never set iMultisampling, so it never compiled the
  alpha to coverage branches. Its "features on" configuration uses the
  default of 2 now, on desktop GL and GLES.
This commit is contained in:
jerrrrycho
2026-11-08 20:03:32 +01:00
parent aecc73e893
commit 04b55c866a
4 changed files with 27 additions and 6 deletions

View File

@@ -1822,6 +1822,10 @@ void opengl33_renderer::setup_matrices()
void opengl33_renderer::setup_alpha_to_coverage(bool const Enable)
{
// the shaders keep the plain alpha test unless told the coverage of their alpha is used;
// uploaded with the rest of the model block at the next draw
model_ubs.alpha_to_coverage = (Enable ? 1.f : 0.f);
if (Enable == m_alphatocoverageenabled)
return;
@@ -2390,11 +2394,13 @@ void opengl33_renderer::Bind_Material( material_handle const Material, TSubModel
// the alpha test drops or keeps whole pixels, so multisampling alone leaves its edges (e.g. sides
// of the trackbed textures) jagged. the alpha tested materials of the opaque colour pass get them
// antialiased with alpha to coverage instead; their shaders give the coverage as the alpha
// antialiased with alpha to coverage instead; their shaders give the coverage as the alpha.
// the model previews draw in colour mode too, but to a single-sampled framebuffer
setup_alpha_to_coverage(
Global.iMultisampling > 0
&& false == m_blendingenabled
&& m_renderpass.draw_mode == rendermode::color
&& false == m_previewing
&& model_ubs.opacity > 0.f
&& material.shader->alpha_to_coverage );