mirror of
https://github.com/MaSzyna-EU07/maszyna.git
synced 2026-11-21 08:35:01 +01:00
fix: a failed start says why and ends with an error code; a small crash dump by default (#425)
* fix: a failed start says why in the log and ends with an error code When the window could not be made, the log only said "Bad init: failed to create glfw window", without the reason glfw knows (no OpenGL driver, no pixel format that fits, no EGL). Sometimes it did not even say that: the log thread writes every 50 ms, and main() ended the process with std::_Exit(0) without stopping it, so a start that failed within that time left a log that ends at "// startup". - glfw's errors go to the log and errors.txt through glfwSetErrorCallback, set before glfwInit(); each distinct message once. - after a failed start (or an exception caught in main) the log thread is stopped and waited for, as the test runs already do, so nothing logged last is lost. - a failed start ends with exit code 1 instead of 0, so the starter can tell it from a closing. A start that worked ends as before. * fix: glfw's errors told during the start only, a closed crash dialog is no failed start After review of the previous commit: - the glfw error callback is taken off at the end of init(). Once the simulator runs, glfw would only repeat what the platform can't do (glfwSetCursorPos on Wayland, on every mouse-look) or what a scenery asks for in vain (launcher key codes below GLFW_KEY_SPACE, checked on every update), which would put new lines in errors.txt of existing sceneries and cost a format and a lock per call. - closing the crash-report window ends the simulator as before, but init() now returns 1 for it (above 0: closed by the player), and only a result below 0 gives exit code 1. - a start that throws from init() (bad_alloc, or a runtime_error on Windows) ends with exit code 1 too; an exception after a start that worked ends with 0 as before. * feat: a small crash dump by default, the full one with "crashdump.full yes" The dump written by the crash handler (Windows, WITHDUMPGEN) held all the memory of the simulator (MiniDumpWithFullMemory), so it was as large as the memory the simulator took: gigabytes on a large scenery, written to the game folder at the moment of the crash, on machines with 8 GB of RAM too. By default it now holds the stacks with the memory they point to, the threads, the modules, the handles, the memory map and the modules' data segments (MiniDumpWithDataSegs in place of MiniDumpWithFullMemory, the rest of the flags as before). The globals, Global among them, stay readable. "crashdump.full yes" in eu07.ini writes the full dump as before. Measured on td.scn with a ghostview camera (1.2 GB committed): the small dump 44 MB in 2 s, the full one 1.6 GB in 19 s. The key is new and optional: eu07.ini files without it read as before, and the setting is listed in the log at start. * fix: the small crash dump keeps the process and thread blocks MiniDumpWithProcessThreadData adds the PEB and the TEBs, a few KB: the command line (the scenery and the vehicle), the environment and the last error of each thread, which the small dump otherwise lacks, since the heap behind Global's longer strings is not in it. * fix: an exception that ends the simulator says what it was in the log After review of #425: - the exceptions main() catches are logged ("Critical error: ..."): on Windows the runtime_error that only showed a message box, and on the other systems any std::exception, which used to end the simulator through std::terminate with no word in the log. On Windows the others are still left to CrashHandler, whose dump shows where they were thrown. - every exception caught there ends with exit code 1, in the start or later, as a crash; it used to be 0 when caught, the abort code when not. - closing the crash-report window logs "Crash report window closed, closing" instead of the error "Failed to run crash gui!", which stays for a result below 0. * feat: the stack of a crash on Linux in the log and on the standard error On Linux no dump is written (the crash handler is Windows only, crashpad is off), so a crash left a log that just stopped. A handler of SIGSEGV, SIGBUS, SIGFPE, SIGILL and SIGABRT (installed at the start of main) now writes, with write() only: Crash: signal 11 (SIGSEGV) at address 0x... Version: EU07 (cmake), <hash> (...) Stack (addr2line -f -C -e <the eu07 file of this version> <offset>): <backtrace_symbols_fd> to the end of the log file (its whole path, set when the log opens it) and to the standard error, which StarterNG shows first. The Linux builds carry their symbols (GENERATE_PDB adds -g, nothing strips them), so addr2line on the eu07 file of the same version gives the files and lines. Then the signal ends the process as before (SA_RESETHAND, raise): the same exit status, and a core dump where the system makes one. The handler runs on an alternate stack, so an overflow of the main thread's stack is reported too; backtrace() is warmed up at install so it doesn't allocate in the handler, and alarm(5) ends a handler that hangs (a crash in the allocator or the loader). WAMR is built without its hardware bound checks, so it installs no SIGSEGV handler of its own. Elsewhere crash_signals does nothing. A unit test (Linux only) crashes a child process and checks the report on its standard error and in the log, and that the child still ended by SIGSEGV. * fix: the crash report can't be cut by a second crash signal or end with SIGALRM After review: - the five crash signals are blocked while a report is written, so a second one waits rather than starting a second report in its middle (a fault that comes while blocked still ends the process). - a report that hangs past alarm(5) ends the process by the signal of the crash, not by SIGALRM: a SIGALRM handler, set only in the crash handler, raises the crash signal and unblocks it. - the child of the unit test calls alarm(10) first, so a child stuck before the crash can't hang the build. --------- Co-authored-by: maj00r <maj00r@host>
This commit is contained in:
89
tests/unit/test_crashsignals.cpp
Normal file
89
tests/unit/test_crashsignals.cpp
Normal file
@@ -0,0 +1,89 @@
|
||||
#include "stdafx.h"
|
||||
#include "doctest.h"
|
||||
#include "scratch.h"
|
||||
|
||||
#include "utilities/crashsignals.h"
|
||||
|
||||
// the stack of a crash on Linux (utilities/crashsignals.h): written to the log and to the standard error, after which
|
||||
// the signal ends the process as it always did. the crash happens in a child process, which the test watches
|
||||
#if defined(__linux__)
|
||||
|
||||
#include <array>
|
||||
#include <csignal>
|
||||
#include <fstream>
|
||||
#include <iterator>
|
||||
#include <string>
|
||||
|
||||
#include <sys/resource.h>
|
||||
#include <sys/wait.h>
|
||||
#include <unistd.h>
|
||||
|
||||
namespace {
|
||||
|
||||
std::string read_all(int const File) {
|
||||
std::string text;
|
||||
std::array<char, 4096> buffer{};
|
||||
for (auto count{::read(File, buffer.data(), buffer.size())}; count > 0; count = ::read(File, buffer.data(), buffer.size()))
|
||||
text.append(buffer.data(), static_cast<std::size_t>(count));
|
||||
return text;
|
||||
}
|
||||
|
||||
std::string read_file(std::string const &Path) {
|
||||
std::ifstream file{Path, std::ios::binary};
|
||||
return {std::istreambuf_iterator<char>{file}, std::istreambuf_iterator<char>{}};
|
||||
}
|
||||
|
||||
// the child: the report goes to the pipe in place of the standard error, no core dump is left behind
|
||||
[[noreturn]] void crash_in_child(std::array<int, 2> const &Pipe, std::string const &Log) {
|
||||
// a child stuck before the crash (a lock some other thread held at the fork) ends anyway, and the test with it
|
||||
alarm(10);
|
||||
dup2(Pipe[1], STDERR_FILENO);
|
||||
close(Pipe[0]);
|
||||
close(Pipe[1]);
|
||||
rlimit const nocore{0, 0};
|
||||
setrlimit(RLIMIT_CORE, &nocore);
|
||||
|
||||
crash_signals::install("test version 1.2");
|
||||
crash_signals::set_log_path(Log);
|
||||
raise(SIGSEGV);
|
||||
_exit(0); // not reached: the signal ends the child
|
||||
}
|
||||
|
||||
} // namespace
|
||||
|
||||
TEST_CASE("crash signals: a crash writes its stack to the log and to the standard error, and still ends by its signal") {
|
||||
test::scratch_folder const folder{"crash_signals"};
|
||||
auto const log{folder.write("log.txt", "the last line of the log\n")};
|
||||
|
||||
std::array<int, 2> pipe_ends{};
|
||||
REQUIRE(pipe(pipe_ends.data()) == 0);
|
||||
auto const child{fork()};
|
||||
REQUIRE(child >= 0);
|
||||
if (child == 0)
|
||||
crash_in_child(pipe_ends, log);
|
||||
|
||||
close(pipe_ends[1]);
|
||||
auto const errors{read_all(pipe_ends[0])};
|
||||
close(pipe_ends[0]);
|
||||
int status{0};
|
||||
REQUIRE(waitpid(child, &status, 0) == child);
|
||||
|
||||
CAPTURE(errors);
|
||||
// the process ends as it would without the handler
|
||||
CHECK(WIFSIGNALED(status));
|
||||
CHECK(WTERMSIG(status) == SIGSEGV);
|
||||
// the report on the standard error, which the starter shows
|
||||
CHECK(errors.find("Crash: signal 11 (SIGSEGV) at address 0x") != std::string::npos);
|
||||
CHECK(errors.find("Version: test version 1.2") != std::string::npos);
|
||||
CHECK(errors.find("Stack (addr2line") != std::string::npos);
|
||||
// with the frames of the program that crashed
|
||||
CHECK(errors.find("eu07_unit_tests") != std::string::npos);
|
||||
// and the same at the end of the log, after what it held
|
||||
auto const logtext{read_file(log)};
|
||||
CAPTURE(logtext);
|
||||
CHECK(logtext.starts_with("the last line of the log\n"));
|
||||
CHECK(logtext.find("Crash: signal 11 (SIGSEGV)") != std::string::npos);
|
||||
CHECK(logtext.find("eu07_unit_tests") != std::string::npos);
|
||||
}
|
||||
|
||||
#endif
|
||||
Reference in New Issue
Block a user