eu07/maszyna
16
0
Fork 0
mirror of https://github.com/MaSzyna-EU07/maszyna.git synced 2026-07-17 22:39:17 +02:00
Code Issues 121 Wiki Activity

Specify auto as reference where possible

Browse Source
This commit is contained in:
docentYT
2026-05-12 19:16:33 +02:00
parent 4fa148e230
commit 2bb8a64877
3 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
network/network.cpp
View File

@@ -125,7 +125,7 @@ void network::server::handle_message(std::shared_ptr<connection> conn, const mes
} }
if (msg.type == message::CLIENT_HELLO) { if (msg.type == message::CLIENT_HELLO) {
auto cmd = dynamic_cast<const client_hello&>(msg); const auto& cmd = dynamic_cast<const client_hello&>(msg);
if (cmd.version != EU07_NETWORK_VERSION // wrong version if (cmd.version != EU07_NETWORK_VERSION // wrong version
|| !Global.ready_to_load) { // not ready yet || !Global.ready_to_load) { // not ready yet
@@ -148,7 +148,7 @@ void network::server::handle_message(std::shared_ptr<connection> conn, const mes
WriteLog("net: client accepted", logtype::net); WriteLog("net: client accepted", logtype::net);
} }
else if (msg.type == message::REQUEST_COMMAND) { else if (msg.type == message::REQUEST_COMMAND) {
auto cmd = dynamic_cast<const request_command&>(msg); const auto& cmd = dynamic_cast<const request_command&>(msg);
for (auto const &kv : cmd.commands) for (auto const &kv : cmd.commands)
client_commands_queue.emplace(kv); client_commands_queue.emplace(kv);
@@ -189,7 +189,7 @@ std::tuple<double, double, command_queue::commands_map> network::client::get_nex
float size = delta_queue.size() - consume_counter; float size = delta_queue.size() - consume_counter;
auto entry = delta_queue.front(); const auto& entry = delta_queue.front();
float mult = entry.render_dt / std::chrono::duration_cast<std::chrono::duration<float>>(frame_time).count(); float mult = entry.render_dt / std::chrono::duration_cast<std::chrono::duration<float>>(frame_time).count();
if (counter == 1 && size < MAX_BUFFER_SIZE * 2.0f) { if (counter == 1 && size < MAX_BUFFER_SIZE * 2.0f) {
@@ -241,7 +241,7 @@ void network::client::handle_message(std::shared_ptr<connection> conn, const mes
} }
if (msg.type == message::SERVER_HELLO) { if (msg.type == message::SERVER_HELLO) {
auto cmd = dynamic_cast<const server_hello&>(msg); const auto& cmd = dynamic_cast<const server_hello&>(msg);
conn->state = connection::ACTIVE; conn->state = connection::ACTIVE;
if (!Global.ready_to_load) { if (!Global.ready_to_load) {

4
rendering/openglrenderer.cpp
View File

@@ -4085,7 +4085,7 @@ opengl_renderer::Update_Pick_Control() {
#endif #endif
m_pickcontrolitem = control; m_pickcontrolitem = control;
// return control; // return control;
for( auto callback : m_control_pick_requests ) { for( auto& callback : m_control_pick_requests ) {
callback( m_pickcontrolitem, glm::vec2() ); callback( m_pickcontrolitem, glm::vec2() );
} }
m_control_pick_requests.clear(); m_control_pick_requests.clear();
@@ -4134,7 +4134,7 @@ opengl_renderer::Update_Pick_Node() {
#endif #endif
m_picksceneryitem = node; m_picksceneryitem = node;
// return node; // return node;
for( auto callback : m_node_pick_requests ) { for( auto& callback : m_node_pick_requests ) {
callback( m_picksceneryitem ); callback( m_picksceneryitem );
} }
m_node_pick_requests.clear(); m_node_pick_requests.clear();

8
scene/scene.cpp
View File

@@ -1021,7 +1021,7 @@ basic_region::on_click( TAnimModel const *Instance ) {
if( Instance->name().empty() || ( Instance->name() == "none" ) ) { return; } if( Instance->name().empty() || ( Instance->name() == "none" ) ) { return; }
auto const location { Instance->location() }; auto const& location { Instance->location() };
if( point_inside( location ) ) { if( point_inside( location ) ) {
section( location ).on_click( Instance ); section( location ).on_click( Instance );
@@ -1296,7 +1296,7 @@ basic_region::insert( shape_node Shape, scratch_data &Scratchpad, bool const Tra
if( ( false == Scratchpad.location.offset.empty() ) if( ( false == Scratchpad.location.offset.empty() )
&& ( Scratchpad.location.offset.top() != glm::dvec3( 0, 0, 0 ) ) ) { && ( Scratchpad.location.offset.top() != glm::dvec3( 0, 0, 0 ) ) ) {
// ...and move // ...and move
auto const offset = Scratchpad.location.offset.top(); auto const& offset = Scratchpad.location.offset.top();
for( auto &vertex : shape.m_data.vertices ) { for( auto &vertex : shape.m_data.vertices ) {
vertex.position += offset; vertex.position += offset;
} }
@@ -1350,7 +1350,7 @@ basic_region::insert( lines_node Lines, scratch_data &Scratchpad ) {
if( ( false == Scratchpad.location.offset.empty() ) if( ( false == Scratchpad.location.offset.empty() )
&& ( Scratchpad.location.offset.top() != glm::dvec3( 0, 0, 0 ) ) ) { && ( Scratchpad.location.offset.top() != glm::dvec3( 0, 0, 0 ) ) ) {
// ...and move // ...and move
auto const offset = Scratchpad.location.offset.top(); auto const &offset = Scratchpad.location.offset.top();
for( auto &vertex : Lines.m_data.vertices ) { for( auto &vertex : Lines.m_data.vertices ) {
vertex.position += offset; vertex.position += offset;
} }
@@ -1726,7 +1726,7 @@ void basic_region::update_poi_geometry()
{ {
std::vector<gfx::basic_vertex> vertices; std::vector<gfx::basic_vertex> vertices;
gfx::userdata_array userdata; gfx::userdata_array userdata;
for (const auto sem : map::Objects.entries) for (const auto &sem : map::Objects.entries)
vertices.push_back(std::move(sem->vertex())); vertices.push_back(std::move(sem->vertex()));
if (!m_map_poipoints) { if (!m_map_poipoints) {