eu07/maszyna
16
0
Fork 0
mirror of https://github.com/MaSzyna-EU07/maszyna.git synced 2026-07-17 23:39:18 +02:00
Code Issues 121 Wiki Activity

fix: correct listener orientation broken by GLM aligned gentypes

Browse Source 
Enabling GLM_FORCE_DEFAULT_ALIGNED_GENTYPES makes glm::vec3 16 bytes (padded),
but the listener orientation was passed to alListenerfv as
reinterpret_cast<ALfloat const *>(glm::vec3[2]). With the padding the six
floats OpenAL reads are at.x, at.y, at.z, PAD, up.x, up.y - the 'up' vector is
taken from padding garbage, corrupting the listener basis (right = at x up) and
swapping left/right of every positional sound.

Build the 6 floats explicitly instead of reinterpreting a padded vec3 array.
This commit is contained in:
maj00r
2026-07-03 21:49:43 +02:00
parent 565aeb0c70
commit 2ffff9193f
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
audio/audiorenderer.cpp
View File

@@ -372,10 +372,14 @@ openal_renderer::update( double const Deltatime ) {
auto cameraposition = Global.pCamera.Pos + glm::dvec3(Global.viewport_move * glm::mat3(cameramatrix));
cameramatrix = glm::dmat4(glm::inverse(Global.viewport_rotate)) * cameramatrix;
auto rotationmatrix { glm::mat3{ cameramatrix } };
glm::vec3 const orientation[] = {
glm::vec3{ 0, 0,-1 } * rotationmatrix ,
glm::vec3{ 0, 1, 0 } * rotationmatrix };
::alListenerfv( AL_ORIENTATION, reinterpret_cast<ALfloat const *>( orientation ) );
// AL_ORIENTATION expects 6 tightly-packed floats (at, then up). Do NOT reinterpret a
// glm::vec3[2] here: with GLM_FORCE_DEFAULT_ALIGNED_GENTYPES a glm::vec3 is 16 bytes
// (padded), so the array is not 6 contiguous floats and the 'up' vector gets read from
// padding as garbage, corrupting the listener basis (left/right swapped).
auto const at { glm::vec3{ 0, 0,-1 } * rotationmatrix };
auto const up { glm::vec3{ 0, 1, 0 } * rotationmatrix };
ALfloat const orientation[ 6 ] = { at.x, at.y, at.z, up.x, up.y, up.z };
::alListenerfv( AL_ORIENTATION, orientation );
// velocity
if( Deltatime > 0 ) {
auto cameramove { cameraposition - cached_camerapos };