From 4533fafd9365be47d61ba25eea22695b364e8b42 Mon Sep 17 00:00:00 2001 From: jerrrrycho Date: Wed, 11 Nov 2026 11:02:59 +0100 Subject: [PATCH] ci: leave yaml-cpp out of the coverage report The first run of the Coverage workflow listed 66 files of betterRenderer/thirdparty/yaml-cpp, all at 0%: the library is linked by every target of the game, so it's built with the coverage flags as well. They made up 4388 of the 16592 lines and took the total from 84.4% to 62.1%. betterRenderer/ is excluded as it is in sonar-project.properties. --- .github/workflows/coverage.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 4577e3795..802213970 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -90,12 +90,14 @@ jobs: - name: Run the unit tests run: ./build/tests/unit/eu07_unit_tests - # the game's own sources only: no submodules, no vendored code, not the tests themselves + # the game's own sources only: no submodules, no vendored code, not the tests themselves. + # betterRenderer/ is left out for its thirdparty/yaml-cpp, which every target of the game links and so builds here - name: Coverage report run: | mkdir -p coverage-report/html gcovr --root . build \ - --exclude 'ref/' --exclude 'imgui/' --exclude 'stb/' --exclude 'tests/' --exclude 'build/' \ + --exclude 'ref/' --exclude 'imgui/' --exclude 'stb/' --exclude 'betterRenderer/' \ + --exclude 'tests/' --exclude 'build/' \ --gcov-ignore-parse-errors=negative_hits.warn_once_per_file \ --gcov-ignore-errors=no_working_dir_found \ --print-summary \