17
0
mirror of https://github.com/MaSzyna-EU07/maszyna.git synced 2026-10-18 00:59:18 +02:00

test: SonarCloud issues of the unit tests

- test::definition_error for unusable test vehicle definitions instead of
  std::runtime_error (S112)
- the rows of a table section written by a function of their own, less
  nesting in definition::text() (S134)
- std::less<> for the section table (S6045)
- comments in the empty methods of the reseeding listener and stub (S1186)
- NOSONAR where the engine's headers fix the stubs: the extern globals
  and the member function signatures (S5421, S5817, S1238)
- NOSONAR on LoadFIZ_Parse(): the cognitive complexity is the former body
  of LoadFIZ(), moved as it was (S3776)
- a comment Sonar took for code reworded (S125)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
jerrrrycho
2026-10-15 06:30:31 +02:00
parent 7b77e4cef8
commit 533746324b
5 changed files with 52 additions and 36 deletions

View File

@@ -16,16 +16,17 @@ public:
void test_case_start(doctest::TestCaseData const &) override { reseed(); }
void test_case_reenter(doctest::TestCaseData const &) override { reseed(); }
void report_query(doctest::QueryData const &) override {}
void test_run_start() override {}
void test_run_end(doctest::TestRunStats const &) override {}
void test_case_end(doctest::CurrentTestCaseStats const &) override {}
void test_case_exception(doctest::TestCaseException const &) override {}
void subcase_start(doctest::SubcaseSignature const &) override {}
void subcase_end() override {}
void log_assert(doctest::AssertData const &) override {}
void log_message(doctest::MessageData const &) override {}
void test_case_skipped(doctest::TestCaseData const &) override {}
// the rest of doctest's reporter interface: a listener reports nothing, the console reporter does that
void report_query(doctest::QueryData const &) override { /* nothing to report */ }
void test_run_start() override { /* nothing to report */ }
void test_run_end(doctest::TestRunStats const &) override { /* nothing to report */ }
void test_case_end(doctest::CurrentTestCaseStats const &) override { /* nothing to report */ }
void test_case_exception(doctest::TestCaseException const &) override { /* nothing to report */ }
void subcase_start(doctest::SubcaseSignature const &) override { /* nothing to report */ }
void subcase_end() override { /* nothing to report */ }
void log_assert(doctest::AssertData const &) override { /* nothing to report */ }
void log_message(doctest::MessageData const &) override { /* nothing to report */ }
void test_case_skipped(doctest::TestCaseData const &) override { /* nothing to report */ }
private:
static void reseed() {