eu07/maszyna
16
0
Fork 0
mirror of https://github.com/MaSzyna-EU07/maszyna.git synced 2026-07-22 11:39:19 +02:00
Code Issues 123 Wiki Activity

avoid div/0 in tangent calculation

Browse Source
This commit is contained in:
milek7
2019-08-31 00:14:39 +02:00
parent 5c84f8b156
commit 63d9d02c5a
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
openglgeometrybank.cpp
View File

@@ -118,7 +118,16 @@ void calculate_tangent(vertex_array &vertices, int type)
float t1 = w2.y - w1.y; float t1 = w2.y - w1.y;
float t2 = w3.y - w1.y; float t2 = w3.y - w1.y;
float r = 1.0F / (s1 * t2 - s2 * t1); float ri = (s1 * t2 - s2 * t1);
if (ri == 0.0f) {
//ErrorLog("Bad model: failed to generate tangent vectors for vertices: " +
// std::to_string(i1) + ", " + std::to_string(i2) + ", " + std::to_string(i3));
// useless error, as we don't have name of problematic model here
// why does it happen?
ri = 1.0f;
}
float r = 1.0f / ri;
glm::vec3 sdir((t2 * x1 - t1 * x2) * r, (t2 * y1 - t1 * y2) * r, glm::vec3 sdir((t2 * x1 - t1 * x2) * r, (t2 * y1 - t1 * y2) * r,
(t2 * z1 - t1 * z2) * r); (t2 * z1 - t1 * z2) * r);
glm::vec3 tdir((s1 * x2 - s2 * x1) * r, (s1 * y2 - s2 * y1) * r, glm::vec3 tdir((s1 * x2 - s2 * x1) * r, (s1 * y2 - s2 * y1) * r,