From 7b3109061ef7a3ca2826b3bf835decc025718295 Mon Sep 17 00:00:00 2001 From: jerrrrycho Date: Sat, 10 Oct 2026 15:05:45 +0200 Subject: [PATCH] refactor(sonar): use =default for trivial special members (cpp:S3490) Co-Authored-By: Claude Opus 5.5 --- environment/moon.cpp | 4 +--- environment/skydome.cpp | 3 +-- environment/sun.cpp | 5 +---- network/manager.cpp | 4 +--- rendering/nullrenderer.h | 4 ++-- utilities/Float3d.h | 4 ++-- utilities/headtrack.cpp | 5 +---- vehicle/AirCoupler.cpp | 4 +--- vehicle/Train.cpp | 2 +- widgets/popup.cpp | 2 +- 10 files changed, 12 insertions(+), 25 deletions(-) diff --git a/environment/moon.cpp b/environment/moon.cpp index 0cd4ce7d..8cc86683 100644 --- a/environment/moon.cpp +++ b/environment/moon.cpp @@ -15,9 +15,7 @@ cMoon::cMoon() { m_observer.temp = 15.0; // ambient dry-bulb temperature, degrees C } -cMoon::~cMoon() { - -} +cMoon::~cMoon() = default; void cMoon::init() { diff --git a/environment/skydome.cpp b/environment/skydome.cpp index 42fe0c29..9e79619d 100644 --- a/environment/skydome.cpp +++ b/environment/skydome.cpp @@ -53,8 +53,7 @@ CSkyDome::CSkyDome (int const Tesselation) : Generate(); } -CSkyDome::~CSkyDome() { -} +CSkyDome::~CSkyDome() = default; //******************************************************************************// diff --git a/environment/sun.cpp b/environment/sun.cpp index 1ecd94ed..998d31dd 100644 --- a/environment/sun.cpp +++ b/environment/sun.cpp @@ -15,10 +15,7 @@ cSun::cSun() { m_observer.temp = 15.0; // ambient dry-bulb temperature, degrees C } -cSun::~cSun() -{ - -} +cSun::~cSun() = default; void cSun::init() { diff --git a/network/manager.cpp b/network/manager.cpp index 37d72401..0c2d50ca 100644 --- a/network/manager.cpp +++ b/network/manager.cpp @@ -55,9 +55,7 @@ void network::server_manager::create_server(const std::string &backend, const st servers.emplace_back(it->second->create_server(backbuffer, conf)); } -network::manager::manager() -{ -} +network::manager::manager() = default; void network::manager::update() { diff --git a/rendering/nullrenderer.h b/rendering/nullrenderer.h index d48e6cf8..d72ba105 100644 --- a/rendering/nullrenderer.h +++ b/rendering/nullrenderer.h @@ -17,7 +17,7 @@ public: // constructors: null_geometrybank() = default; // destructor - ~null_geometrybank() {}; + ~null_geometrybank() = default; private: // methods: @@ -43,7 +43,7 @@ public: // constructors null_renderer() = default; // destructor - ~null_renderer() { } + ~null_renderer() = default; // methods bool Init( GLFWwindow *Window ) override { return true; } diff --git a/utilities/Float3d.h b/utilities/Float3d.h index 08b4987f..4ff67a3c 100644 --- a/utilities/Float3d.h +++ b/utilities/Float3d.h @@ -18,7 +18,7 @@ class float3 float x; float y; float z; - float3(void){}; + float3() = default; float3(float a, float b, float c) { x = a; @@ -218,7 +218,7 @@ public: void deserialize_float32(std::istream&); void deserialize_float64(std::istream&); void serialize_float32(std::ostream&); - float4x4(void){}; + float4x4() = default; float4x4(const float f[16]) { for (int i = 0; i < 16; ++i) diff --git a/utilities/headtrack.cpp b/utilities/headtrack.cpp index caf62bee..2094a217 100644 --- a/utilities/headtrack.cpp +++ b/utilities/headtrack.cpp @@ -2,10 +2,7 @@ #include "utilities/headtrack.h" #include "utilities/Globals.h" -headtrack::headtrack() -{ - -} +headtrack::headtrack() = default; void headtrack::find_joy() { for (size_t i = GLFW_JOYSTICK_1; i <= GLFW_JOYSTICK_LAST; i++) { diff --git a/vehicle/AirCoupler.cpp b/vehicle/AirCoupler.cpp index 81253d60..97b8fd7b 100644 --- a/vehicle/AirCoupler.cpp +++ b/vehicle/AirCoupler.cpp @@ -18,9 +18,7 @@ AirCoupler::AirCoupler() Clear(); } -AirCoupler::~AirCoupler() -{ -} +AirCoupler::~AirCoupler() = default; /** * \return 1 when \(straight\) TModel3d \c only ModelOn exists diff --git a/vehicle/Train.cpp b/vehicle/Train.cpp index 859f61df..f2111bf5 100644 --- a/vehicle/Train.cpp +++ b/vehicle/Train.cpp @@ -632,7 +632,7 @@ TTrain::TTrain() } } -TTrain::~TTrain() {} +TTrain::~TTrain() = default; bool TTrain::Init(TDynamicObject *NewDynamicObject, bool e3d) { // powiązanie ręcznego sterowania kabiną z pojazdem diff --git a/widgets/popup.cpp b/widgets/popup.cpp index 75633c38..64f7a634 100644 --- a/widgets/popup.cpp +++ b/widgets/popup.cpp @@ -3,7 +3,7 @@ ui::popup::popup(ui_panel &panel) : m_parent(panel) {} -ui::popup::~popup() {} +ui::popup::~popup() = default; bool ui::popup::render() {