18
0
mirror of https://github.com/MaSzyna-EU07/maszyna.git synced 2026-11-20 09:15:01 +01:00

fix(ai): a brake cut-out skipped on the run is done once the train stands

A train formed by coupling is inspected at the first buffer contact, above the
speed the inspector takes for a standstill, so its wagons without G kept their
brakes (Cw-1 §19.9) until some later stop, if any. brake_setting::apply() now
tells when it left a cut-out because the train was moving; AutoRewident keeps
that as a pending re-inspection and TController::reinspect_brakes() runs it
again once the train is below EU07_AI_MOVEMENT. The flag is dropped when the
order stops being a train run. The legacy inspector (ai.brakesetting.cw1 no)
never cuts a brake out and is unchanged.
This commit is contained in:
jerrrrycho
2026-11-11 08:17:06 +01:00
parent a1335c1586
commit 9043d2d5fc
5 changed files with 141 additions and 20 deletions

View File

@@ -2435,9 +2435,10 @@ void TController::AutoRewident()
// brakes are cut out (Cw-1 §19.9) only in a train (a bank engine's run included), not in a consist being shunted
auto const train{brake_setting::runs_as_train(OrderCurrentGet())};
auto const settings{Global.AIBrakeSettingCw1 ? brake_setting::choose(consist, train) : brake_setting::choose_legacy(consist)};
// and only at a standstill, the train creeping to a stop or coupling included: a check on the run (the order changed
// mid-run) leaves them to the next one
// and only at a standstill, the train creeping to a stop included: a check on the run (the order changed mid-run, or
// the train was just formed by coupling, which the AI does above that speed) leaves them to reinspect_brakes()
auto const standstill{brake_setting::at_standstill(mvOccupied->Vel)};
auto reinspect{false};
// a light engine counts as a passenger train for the braking below
auto const passengertrain{brake_setting::passenger(brake_setting::choose_train_setting(consist))};
// 3. Nastawianie
@@ -2448,11 +2449,15 @@ void TController::AutoRewident()
continue;
}
// the setting, a brake cut out in a train on G (Cw-1 §19.9) or put back when the train no longer needs it cut out
brake_setting::apply(*d->MoverParameters, *setting, standstill);
if (brake_setting::apply(*d->MoverParameters, *setting, standstill)) {
// a brake to cut out, with the train moving: left for the next standstill
reinspect = true;
}
// potentially release manual brake
d->MoverParameters->DecManualBrakeLevel( ManualBrakePosNo );
d->MoverParameters->SpringBrake.Activate = false;
}
BrakeReinspectionPending = reinspect;
//ustawianie trybu pracy zadajnika hamulca, wystarczy raz po inicjalizacji AI
if( true == AIControllFlag ) {
// if a human is in charge leave the brake mode up to them, otherwise do as you like
@@ -2545,6 +2550,25 @@ void TController::AutoRewident()
}
// a brake the inspector had to cut out (Cw-1 §19.9) while the train was moving gets cut out once the train stands.
// a train formed by coupling is looked at as the buffers meet, above the speed the inspector takes for a standstill,
// and with no stop ahead nothing would look at it standing again (eu07/maszyna#350)
void TController::reinspect_brakes()
{
if (false == BrakeReinspectionPending) {
return;
}
if (false == brake_setting::runs_as_train(OrderCurrentGet())) {
// no longer a train: nothing is cut out in a consist being shunted
BrakeReinspectionPending = false;
return;
}
if (brake_setting::at_standstill(mvOccupied->Vel)) {
// standing, the inspector leaves nothing for later: this clears the flag
AutoRewident();
}
}
double TController::ESMVelocity(bool Main)
{
double fCurrentCoeff = 0.9;
@@ -5320,6 +5344,8 @@ TController::Update( double const Timedelta ) {
// mode specific actions
handle_engine();
handle_orders();
// a brake the wagon inspector left to cut out while the train was moving
reinspect_brakes();
// situational velocity and acceleration adjustments
pick_optimal_speed( awarenessrange );
if( iEngineActive ) {