eu07/maszyna
17
0
Fork 0
mirror of https://github.com/MaSzyna-EU07/maszyna.git synced 2026-10-17 06:19:19 +02:00
Code Issues 150 Wiki Activity

refactor(sonar): use try_emplace for map insertion (cpp:S6030)

Browse Source 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
jerrrrycho
2026-10-10 15:51:29 +02:00
parent 6547f7e967
commit 95bc9bd511
17 changed files with 64 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gl/shader.cpp
View File

@@ -228,7 +228,7 @@ void gl::shader::parse_texture_entries(std::string &str)
else if (conf.id >= gl::MAX_TEXTURES)
log_error("invalid texture binding: " + std::to_string(conf.id));
else
texture_conf.emplace(std::make_pair(name, conf));
texture_conf.try_emplace(name, conf);
}
else
log_error("invalid argument count to #texture");
@@ -289,7 +289,7 @@ void gl::shader::parse_param_entries(std::string &str)
else if (conf.offset + conf.size > 4)
log_error("invalid size: " + std::to_string(conf.size));
else
param_conf.emplace(std::make_pair(name, conf));
param_conf.try_emplace(name, conf);
}
else
log_error("invalid argument count to #param");
@@ -379,9 +379,9 @@ gl::program::program(std::vector<std::reference_wrapper<const gl::shader>> shade
void gl::program::attach(const gl::shader &s)
{
for (auto it : s.texture_conf)
texture_conf.emplace(std::make_pair(it.first, std::move(it.second)));
texture_conf.try_emplace(it.first, std::move(it.second));
for (auto it : s.param_conf)
param_conf.emplace(std::make_pair(it.first, std::move(it.second)));
param_conf.try_emplace(it.first, std::move(it.second));
glAttachShader(*this, *s);
}