From 96161dcacbea0bf8d42914b00c0e9bca90ad0fc6 Mon Sep 17 00:00:00 2001 From: maj00r Date: Thu, 10 Sep 2026 02:40:50 +0200 Subject: [PATCH] include the platform header where Win32 types are used windows.cpp and piped_proc.cpp reached windows.h through an imported module's global module fragment, which does not cross the boundary. LPT.cpp and zmq_input.cpp never had it at all - the first was in an MSBuild batch that aborted before reaching it, the second is behind WITH_ZMQ and has not been compiled by either CI job. The earlier sweep only looked inside #ifdef _WIN32 blocks, but these files are gated by CMake instead, so they have no such block. --- Console/LPT.cpp | 1 + Console/PoKeys55.cpp | 1 + extras/piped_proc.cpp | 3 +++ input/zmq_input.cpp | 1 + windows.cpp | 1 + 5 files changed, 7 insertions(+) diff --git a/Console/LPT.cpp b/Console/LPT.cpp index 441fcaa7..e218f865 100644 --- a/Console/LPT.cpp +++ b/Console/LPT.cpp @@ -1,4 +1,5 @@ module; +#include "winheaders.h" // HINSTANCE #include module eu07.console.lpt; diff --git a/Console/PoKeys55.cpp b/Console/PoKeys55.cpp index d6e3751c..bd4af51d 100644 --- a/Console/PoKeys55.cpp +++ b/Console/PoKeys55.cpp @@ -1,4 +1,5 @@ module; +#include "winheaders.h" // HANDLE; setupapi.h happens to pull it in, but say so #include #include #include diff --git a/extras/piped_proc.cpp b/extras/piped_proc.cpp index 7fa24717..5723a556 100644 --- a/extras/piped_proc.cpp +++ b/extras/piped_proc.cpp @@ -1,4 +1,7 @@ module; +#ifdef _WIN32 +#include "winheaders.h" // the interface has this in its own fragment, which does not cross +#endif #include #include #include diff --git a/input/zmq_input.cpp b/input/zmq_input.cpp index a462bacf..95c96963 100644 --- a/input/zmq_input.cpp +++ b/input/zmq_input.cpp @@ -1,4 +1,5 @@ module; +#include "winheaders.h" // SYSTEMTIME #include #include #include diff --git a/windows.cpp b/windows.cpp index d8e237ce..173f3f04 100644 --- a/windows.cpp +++ b/windows.cpp @@ -1,3 +1,4 @@ +#include "winheaders.h" #include "utilities/utilities_macros.h" #include #include