17
0
mirror of https://github.com/MaSzyna-EU07/maszyna.git synced 2026-11-03 22:22:04 +01:00

refactor(sonar): assorted small fixes

- empty() instead of size() comparisons (cpp:S1155)
- member initialisers in declaration order (cpp:S3229)
- no redundant c_str() when a std::string is accepted (cpp:S7121)
- contains() on associative containers (cpp:S6171)
- const reference instead of a copying range-for (cpp:S6032)
- starts_with() for prefix checks (cpp:S6178)
- no std::move on temporaries (cpp:S5274)
- has_value() on std::optional (cpp:S7172)
- bool literals for bool members (cpp:S5820)
- inline only on the definition (cpp:S3548)
- explicit base access specifier (cpp:S5965)
- explicit element access instead of dereferencing an array (cpp:S7116)
- rely on the C++20 rewritten operator!= (cpp:S6186)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
jerrrrycho
2026-10-10 17:50:12 +02:00
parent 2e92076e21
commit b6186ced21
16 changed files with 28 additions and 29 deletions

View File

@@ -256,7 +256,7 @@ void TSecuritySystem::load(std::string const &line, double Vmax)
double TableInterpolation(std::map<double, double> &Map, double Parameter)
{
if (Map.size() == 0)
if (Map.empty())
return 0.0;
if (Map.size() == 1)
return Map.begin()->second;
@@ -7868,7 +7868,7 @@ double TMoverParameters::dizel_fillcheck(int mcp, double dt)
else
dizel_nreg_min = dizel_nmin;
}
if (dizel_vel2nmax_Table.size() > 0 && !hydro_TC_Lockup)
if (!dizel_vel2nmax_Table.empty() && !hydro_TC_Lockup)
{
dizel_nreg_max = std::min(std::min(dizel_nreg_max, enrot) + dizel_nreg_acc * dt, TableInterpolation(dizel_vel2nmax_Table, Vel));
}