eu07/maszyna
17
0
Fork 0
mirror of https://github.com/MaSzyna-EU07/maszyna.git synced 2026-10-30 13:10:29 +01:00
Code Issues 154 Wiki Activity

refactor(sonar): assorted small fixes

Browse Source 
- empty() instead of size() comparisons (cpp:S1155)
- member initialisers in declaration order (cpp:S3229)
- no redundant c_str() when a std::string is accepted (cpp:S7121)
- contains() on associative containers (cpp:S6171)
- const reference instead of a copying range-for (cpp:S6032)
- starts_with() for prefix checks (cpp:S6178)
- no std::move on temporaries (cpp:S5274)
- has_value() on std::optional (cpp:S7172)
- bool literals for bool members (cpp:S5820)
- inline only on the definition (cpp:S3548)
- explicit base access specifier (cpp:S5965)
- explicit element access instead of dereferencing an array (cpp:S7116)
- rely on the C++20 rewritten operator!= (cpp:S6186)
This commit is contained in:
jerrrrycho
2026-10-10 17:50:12 +02:00
parent ce450012b6
commit ba6840b6ba
16 changed files with 28 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
vehicle/Train.cpp
View File

@@ -79,7 +79,7 @@ std::string control_mapper::find(TSubModel const *Control) const
bool control_mapper::contains(std::string const &Control) const
{
return m_names.find(Control) != m_names.end();
return m_names.contains(Control);
}
void TTrain::screen_entry::deserialize(cParser &Input)