mirror of
https://github.com/MaSzyna-EU07/maszyna.git
synced 2026-11-20 13:54:58 +01:00
refactor(renderer): a material's textures let go of in one place, for every backend
Unload_Material walked the textures of a material and of its variants the same way in both opengl renderers, and Sonar counted its declarations, set into the long run of overrides the two headers share, as duplicated: 5.2% of the new code, 3% allowed. The walk is gfx_renderer's now, over IMaterial::GetAllTextures and the backend's Unload_Texture. Materials that don't tell their textures, the Vulkan renderer's, give none, and are left alone as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -66,6 +66,13 @@ struct opengl_material : public IMaterial {
|
||||
{
|
||||
return textures[slot];
|
||||
}
|
||||
virtual std::vector<texture_handle> GetAllTextures() const override
|
||||
{
|
||||
std::vector<texture_handle> all(textures.begin(), textures.end());
|
||||
for (auto const &variant : texture_variants)
|
||||
all.insert(all.end(), variant.begin(), variant.end());
|
||||
return all;
|
||||
}
|
||||
// returns texture set to use for model instance identified by provided variant id
|
||||
texture_set const &GetTextures(std::uint32_t const Variant) const
|
||||
{
|
||||
|
||||
Reference in New Issue
Block a user