From c008d0cdca9d745475b4ecc20f0fb05977b31ea7 Mon Sep 17 00:00:00 2001 From: jerrrrycho Date: Wed, 11 Nov 2026 11:03:09 +0100 Subject: [PATCH] ci: fail the coverage report step when gcovr fails The step pipes gcovr into tee, and the default shell of a run step has no pipefail: an error of gcovr after it printed the totals would have left the step green with an incomplete report. --- .github/workflows/coverage.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 802213970..f580c5a16 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -94,6 +94,8 @@ jobs: # betterRenderer/ is left out for its thirdparty/yaml-cpp, which every target of the game links and so builds here - name: Coverage report run: | + # a failure of gcovr fails the step, though its output goes through tee + set -o pipefail mkdir -p coverage-report/html gcovr --root . build \ --exclude 'ref/' --exclude 'imgui/' --exclude 'stb/' --exclude 'betterRenderer/' \