mirror of
https://github.com/MaSzyna-EU07/maszyna.git
synced 2026-10-17 02:49:19 +02:00
* refactor(sonar): use override instead of redundant virtual (cpp:S3471) * refactor(sonar): remove empty statements, one declaration per statement (cpp:S1116, cpp:S1659) * refactor(sonar): drop redundant lambda return types (cpp:S3574) * refactor(sonar): prefer using over typedef (cpp:S5416) * refactor(sonar): use =default for trivial special members (cpp:S3490) * refactor(sonar): use nullptr literal (cpp:S4962) * refactor(sonar): remove redundant access specifiers (cpp:S3539) * refactor(sonar): remove redundant casts (cpp:S1905) * refactor(sonar): use std::scoped_lock instead of std::lock_guard (cpp:S5997) * refactor(sonar): construct elements in place with emplace_back (cpp:S6003) * refactor(sonar): make narrowing conversions explicit (cpp:S5276) * refactor(sonar): mark unused parameters (cpp:S1172) Unused names are commented out; parameters used only on some platforms are marked [[maybe_unused]]. * refactor(sonar): declare non-mutating member functions const (cpp:S5817) Virtual functions are left untouched so overrides keep matching. * refactor(sonar): merge collapsible nested if statements (cpp:S1066) Comments that preceded the inner if are kept above the merged statement. * refactor(sonar): scope single-use variables in if init-statements (cpp:S6004) * fix(sonar): give polymorphic base classes virtual destructors (cpp:S1235) * refactor(sonar): use try_emplace for map insertion (cpp:S6030) * refactor(sonar): use auto where the type is spelled out on the right (cpp:S5827) * refactor(sonar): remove redundant parentheses (cpp:S1110) * refactor(sonar): document intentionally empty functions (cpp:S1186) * refactor(sonar): remove dead stores (cpp:S1854) Side effects (e.g. LISTLINE++) are kept. * refactor(sonar): remove unused variables, captures and private fields (cpp:S1481, cpp:S1068) * refactor(sonar): use structured bindings for pair access (cpp:S6005) * refactor(sonar): use range-based loops and ranges algorithms (cpp:S5566) * refactor(sonar): split chained assignments (cpp:S1121) * refactor(sonar): add default cases to switch statements (cpp:S3562) * refactor(sonar): use std::size for array lengths (cpp:S7127) * refactor(sonar): use std::ranges algorithms and std::erase(_if) (cpp:S6197) * refactor(sonar): access static members through the class (cpp:S2209) * refactor(sonar): add braces around nested if-else (cpp:S5261) * refactor(sonar): avoid side effects inside typeid operands (cpp:S5279) * refactor(sonar): drop top-level const from by-value return types (cpp:S5951) * refactor(sonar): declare variables separately from their type definitions (cpp:S3646) * refactor(sonar): declare loop counters in the for statement (cpp:S5955) * refactor(sonar): rely on class template argument deduction (cpp:S6012) * refactor(sonar): inherit base constructors instead of forwarding them (cpp:S5952) * refactor(sonar): rename locals that shadow outer declarations (cpp:S1117) Only local variables and definition parameters are renamed; shadowing struct fields and enumerators in headers are left for a separate change. * refactor(sonar): reduce enum qualification with using enum (cpp:S6177) Applied only where no unqualified name in the block could be captured by the introduced enumerators. * refactor(sonar): mark converting constructors explicit (cpp:S1709) sound_source and the gl::object conversion operators stay implicit; they are relied upon by copy-list-initialisation and GL calls. * refactor(sonar): initialise members in initialiser lists or declarations (cpp:S3230) * refactor(sonar): make read-only local references and pointers const (cpp:S5350) * refactor(sonar): take read-only pointer and reference parameters as const (cpp:S995) TTrain command handlers keep their signature, it is fixed by the handler table. * refactor(sonar): pass expensive-to-copy parameters by const reference (cpp:S1238) Signatures declared in files touched by PR 206 (Driver.h, EU07.cpp) and virtual overrides are left unchanged. * refactor(sonar): use transparent comparators for string-keyed maps (cpp:S6045) std::unordered_map instances and map types exposed in headers used by other modules are left as they are. * fix(sonar): do not use UI text as a printf format string (cpp:S5281) Text lines containing '%' would otherwise be interpreted as format specifiers by ImGui::TextColored. * refactor(sonar): use std::bind_front for callbacks (cpp:S5995) * refactor(sonar): drop const_cast on string literals passed to the Python C API (cpp:S859) * refactor(sonar): take read-only string parameters as std::string_view (cpp:S6009) The Windows messaging helpers keep std::string, they need c_str(). * refactor(sonar): make read-only global tables const (cpp:S5421) Mutable global state (flags, timers, singletons) is left as is. * refactor(sonar): replace single-case switch statements with if (cpp:S1301) * refactor(sonar): format UUIDs and log timestamps with std::format (cpp:S6494, cpp:S5945) * refactor(sonar): use std::array for local fixed-size arrays (cpp:S5945) Arrays that are class members or part of headers are left unchanged. * fix(sonar): test the bearing damage bit, not bit 0 (cpp:S872) 'DamageFlag & dtrain_bearing > 0' parsed as 'DamageFlag & (dtrain_bearing > 0)', i.e. DamageFlag & 1, so bearing friction reacted to the wrong damage flag. * refactor(sonar): assorted small fixes - empty() instead of size() comparisons (cpp:S1155) - member initialisers in declaration order (cpp:S3229) - no redundant c_str() when a std::string is accepted (cpp:S7121) - contains() on associative containers (cpp:S6171) - const reference instead of a copying range-for (cpp:S6032) - starts_with() for prefix checks (cpp:S6178) - no std::move on temporaries (cpp:S5274) - has_value() on std::optional (cpp:S7172) - bool literals for bool members (cpp:S5820) - inline only on the definition (cpp:S3548) - explicit base access specifier (cpp:S5965) - explicit element access instead of dereferencing an array (cpp:S7116) - rely on the C++20 rewritten operator!= (cpp:S6186) * refactor(sonar): more small fixes - std::format instead of iostream manipulators in to_string/to_hex_str (cpp:S6495); output verified identical, negative hex values keep the unsigned form - remove an empty compound statement (cpp:S108) - drop an always-false unsigned < 0 branch (cpp:S1768) - explicit lambda capture (cpp:S3608) - std::make_unique (cpp:S5950) * chore: strip stray carriage returns left in TTrain constructor comments * fix: keep quantize() in its own value type The S5276 change cast the result of the generic quantize<Type_>() to unsigned int, which truncated float/double callers (shadow angle slider, editor rotation snapping, AI speed control steps) and broke negative values. * fix(sonar): use integer loop counters in segment sampling (cpp:S2193) * refactor(sonar): clean up issues reported on PR 209 - remove locals left unused after the dead-store cleanup (cpp:S1481, cpp:S1854) - unnamed unused parameter (cpp:S1172) - single-use declarations moved into if init-statements (cpp:S6004) - auto for casted initialisers (cpp:S5827) - const references and pointers where nothing is modified (cpp:S5350) - rename structured bindings shadowed by inner declarations (cpp:S1117)
269 lines
10 KiB
C++
269 lines
10 KiB
C++
/*
|
|
This Source Code Form is subject to the
|
|
terms of the Mozilla Public License, v.
|
|
2.0. If a copy of the MPL was not
|
|
distributed with this file, You can
|
|
obtain one at
|
|
http://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "audio/audiorenderer.h"
|
|
#include "utilities/Classes.h"
|
|
#include "utilities/Names.h"
|
|
|
|
float const EU07_SOUND_GLOBALRANGE { -1.f };
|
|
float const EU07_SOUND_CABCONTROLSCUTOFFRANGE { 7.5f };
|
|
float const EU07_SOUND_CABANNOUNCEMENTCUTOFFRANGE{ -10.f };
|
|
float const EU07_SOUND_BRAKINGCUTOFFRANGE { 100.f };
|
|
float const EU07_SOUND_RUNNINGNOISECUTOFFRANGE { 200.f };
|
|
float const EU07_SOUND_HANDHELDRADIORANGE { 3500.f };
|
|
|
|
enum class sound_type {
|
|
single,
|
|
multipart
|
|
};
|
|
|
|
enum sound_parameters {
|
|
range = 0x1,
|
|
amplitude = 0x2,
|
|
frequency = 0x4,
|
|
};
|
|
|
|
enum sound_flags {
|
|
looping = 0x1, // the main sample will be looping
|
|
exclusive = 0x2, // the source won't dispatch more than one active instance of the sound
|
|
event = 0x80 // sound was activated by an event; we should keep note of the activation state for the update() calls it may receive
|
|
};
|
|
|
|
enum class sound_placement {
|
|
general, // source is equally audible in potential carrier and outside of it
|
|
internal, // source is located inside of the carrier, and less audible when the listener is outside
|
|
engine, // source is located in the engine compartment, less audible when the listener is outside and even less in the cabs
|
|
external, // source is located on the outside of the carrier, and less audible when the listener is inside
|
|
external_ambient, // source is located on the outside of the carrier, with fixed volume
|
|
custom, // source doesn't fit in any standard location or requires custom soundproofing
|
|
};
|
|
|
|
auto const EU07_SOUNDPROOFING_NONE{ 1.f };
|
|
auto const EU07_SOUNDPROOFING_SOME{ std::sqrt( 0.65f ) };
|
|
auto const EU07_SOUNDPROOFING_STRONG{ std::sqrt( 0.20f ) };
|
|
auto const EU07_SOUNDPROOFING_VERYSTRONG{ std::sqrt( 0.01f ) };
|
|
|
|
// mini controller and audio dispatcher; issues play commands for the audio renderer,
|
|
// updates parameters of created audio emitters for the playback duration
|
|
// TODO: move to simulation namespace after clean up of owner classes
|
|
class sound_source {
|
|
|
|
public:
|
|
// constructors
|
|
sound_source( sound_placement const Placement = sound_placement::general, float const Range = 50.f );
|
|
|
|
// destructor
|
|
~sound_source();
|
|
|
|
// methods
|
|
// restores state of the class from provided data stream
|
|
sound_source &
|
|
deserialize( cParser &Input, sound_type const Legacytype, int const Legacyparameters = 0, int const Chunkrange = 100 );
|
|
sound_source &
|
|
deserialize( std::string const &Input, sound_type const Legacytype, int const Legacyparameters = 0 );
|
|
// sends content of the class in legacy (text) format to provided stream
|
|
void
|
|
export_as_text( std::ostream &Output ) const;
|
|
// copies list of sounds from provided source
|
|
sound_source &
|
|
copy_sounds( sound_source const &Source );
|
|
// issues contextual play commands for the audio renderer
|
|
void
|
|
play( int const Flags = 0 );
|
|
// maintains playback of sounds started by event
|
|
void
|
|
play_event();
|
|
// stops currently active play commands controlled by this emitter
|
|
void
|
|
stop( bool const Skipend = false );
|
|
// adjusts parameters of provided implementation-side sound source
|
|
void
|
|
update( audio::openal_source &Source );
|
|
// sets base volume of the emiter to specified value
|
|
sound_source &
|
|
gain( float const Gain );
|
|
// returns current base volume of the emitter
|
|
float
|
|
gain() const;
|
|
// sets base pitch of the emitter to specified value
|
|
sound_source &
|
|
pitch( float const Pitch );
|
|
// owner setter/getter
|
|
void
|
|
owner( TDynamicObject const *Owner );
|
|
TDynamicObject const *
|
|
owner() const;
|
|
// sound source offset setter/getter
|
|
void
|
|
offset( glm::vec3 const Offset );
|
|
glm::vec3 const &
|
|
offset() const;
|
|
// sound source name setter/getter
|
|
void
|
|
name( std::string const &Name );
|
|
std::string const &
|
|
name() const;
|
|
// playback starting point shift setter/getter
|
|
void
|
|
start( float const Offset );
|
|
float const &
|
|
start() const;
|
|
// custom soundproofing setter/getter
|
|
auto &
|
|
soundproofing();
|
|
auto const &
|
|
soundproofing() const;
|
|
// returns true if there isn't any sound buffer associated with the object, false otherwise
|
|
bool
|
|
empty() const;
|
|
// returns true if the source is emitting any sound; by default doesn't take into account optional ending soudnds
|
|
bool
|
|
is_playing( bool const Includesoundends = false ) const;
|
|
// returns true if the source uses sample table
|
|
bool
|
|
is_combined() const;
|
|
// returns true if specified buffer is one of the optional bookends
|
|
bool
|
|
is_bookend( audio::buffer_handle const Buffer ) const;
|
|
// returns true if the source has optional bookends
|
|
bool
|
|
has_bookends() const;
|
|
// returns location of the sound source in simulation region space
|
|
glm::dvec3
|
|
location() const;
|
|
// returns defined range of the sound
|
|
void
|
|
range( float const Range );
|
|
float
|
|
range() const;
|
|
|
|
// members
|
|
float m_amplitudefactor { 1.f }; // helper, value potentially used by gain calculation
|
|
float m_amplitudeoffset { 0.f }; // helper, value potentially used by gain calculation
|
|
float m_frequencyfactor { 1.f }; // helper, value potentially used by pitch calculation
|
|
float m_frequencyoffset { 0.f }; // helper, value potentially used by pitch calculation
|
|
|
|
private:
|
|
// types
|
|
struct sound_data {
|
|
audio::buffer_handle buffer;
|
|
int playing; // number of currently active sample instances
|
|
};
|
|
|
|
struct chunk_data {
|
|
int threshold; // nominal point of activation for the given chunk
|
|
float fadein; // actual activation point for the given chunk
|
|
float fadeout; // actual end point of activation range for the given chunk
|
|
float pitch; // base pitch of the chunk
|
|
};
|
|
|
|
using soundchunk_pair = std::pair<sound_data, chunk_data>;
|
|
|
|
using sound_handle = std::uint32_t;
|
|
enum sound_id : std::uint32_t {
|
|
begin,
|
|
main,
|
|
end,
|
|
// 31 bits for index into relevant array, msb selects between the sample table and the basic array
|
|
chunk = 1u << 31
|
|
};
|
|
|
|
// methods
|
|
// imports member data pair from the provided data stream
|
|
bool
|
|
deserialize_mapping( cParser &Input );
|
|
// imports values for initial, main and ending sounds from provided data stream
|
|
void
|
|
deserialize_soundset( cParser &Input );
|
|
// issues contextual play commands for the audio renderer
|
|
void
|
|
play_basic();
|
|
void
|
|
play_combined();
|
|
// calculates requested sound point, used to select specific sample from the sample table
|
|
float
|
|
compute_combined_point() const;
|
|
void
|
|
update_basic( audio::openal_source &Source );
|
|
void
|
|
update_combined( audio::openal_source &Source );
|
|
void
|
|
update_crossfade( sound_handle const Chunk );
|
|
void
|
|
update_counter( sound_handle const Sound, int const Value );
|
|
void
|
|
update_location();
|
|
// potentially updates area-based gain factor of the source. returns: true if location has changed
|
|
bool
|
|
update_soundproofing();
|
|
void
|
|
insert( sound_handle const Sound );
|
|
template <class Iterator_>
|
|
void
|
|
insert( Iterator_ First, Iterator_ Last ) {
|
|
update_counter( *First, 1 );
|
|
std::vector<audio::buffer_handle> buffers;
|
|
uint32_sequence sounds;
|
|
std::for_each(
|
|
First, Last,
|
|
[&]( sound_handle const &soundhandle ) {
|
|
buffers.emplace_back( sound( soundhandle ).buffer );
|
|
sounds.emplace_back( soundhandle ); } );
|
|
audio::renderer.insert( std::begin( buffers ), std::end( buffers ), this, sounds ); }
|
|
sound_data &
|
|
sound( sound_handle const Sound );
|
|
sound_data const &
|
|
sound( sound_handle const Sound ) const;
|
|
|
|
// members
|
|
TDynamicObject const * m_owner { nullptr }; // optional, the vehicle carrying this sound source
|
|
glm::vec3 m_offset; // relative position of the source, either from the owner or the region centre
|
|
sound_placement m_placement;
|
|
float m_range { 50.f }; // audible range of the emitted sounds
|
|
std::string m_name;
|
|
int m_flags {}; // requested playback parameters
|
|
sound_properties m_properties; // current properties of the emitted sounds
|
|
float m_pitchvariation {}; // emitter-specific shift for base pitch
|
|
float m_startoffset {}; // emitter-specific shift for playback starting point
|
|
bool m_stop { false }; // indicates active sample instances should be terminated
|
|
/*
|
|
bool m_stopend { false }; // indicates active instances of optional ending sound should be terminated
|
|
*/
|
|
bool m_playbeginning { true }; // indicates started sounds should be preceeded by opening bookend if there's one
|
|
std::array<sound_data, 3> m_sounds { {} }; // basic sounds emitted by the source, main and optional bookends
|
|
std::vector<soundchunk_pair> m_soundchunks; // table of samples activated when associated variable is within certain range
|
|
bool m_soundchunksempty { true }; // helper, cached check whether sample table is linked with any actual samples
|
|
int m_crossfaderange {}; // range of transition from one chunk to another
|
|
std::optional< std::array<float, 6> > m_soundproofing; // custom soundproofing parameters
|
|
};
|
|
|
|
// owner setter/getter
|
|
inline void sound_source::owner( TDynamicObject const *Owner ) { m_owner = Owner; }
|
|
inline TDynamicObject const * sound_source::owner() const { return m_owner; }
|
|
// sound source offset setter/getter
|
|
inline void sound_source::offset( glm::vec3 const Offset ) { m_offset = Offset; }
|
|
inline glm::vec3 const & sound_source::offset() const { return m_offset; }
|
|
// sound source name setter/getter
|
|
inline void sound_source::name( std::string const &Name ) { m_name = Name; }
|
|
inline std::string const & sound_source::name() const { return m_name; }
|
|
// playback starting point shift setter/getter
|
|
inline void sound_source::start( float const Offset ) { m_startoffset = Offset; }
|
|
inline float const & sound_source::start() const { return m_startoffset; }
|
|
// custom soundproofing setter/getter
|
|
inline auto & sound_source::soundproofing() { return m_soundproofing; }
|
|
inline auto const & sound_source::soundproofing() const { return m_soundproofing; }
|
|
|
|
|
|
// collection of sound sources present in the scene
|
|
class sound_table : public basic_table<sound_source> {
|
|
|
|
};
|