eu07/maszyna
17
0
Fork 0
mirror of https://github.com/MaSzyna-EU07/maszyna.git synced 2026-11-04 19:59:25 +01:00
Code Issues 156 Wiki Activity

refactor(sonar): clean up issues reported on PR 209

Browse Source 
- remove locals left unused after the dead-store cleanup (cpp:S1481, cpp:S1854)
- unnamed unused parameter (cpp:S1172)
- single-use declarations moved into if init-statements (cpp:S6004)
- auto for casted initialisers (cpp:S5827)
- const references and pointers where nothing is modified (cpp:S5350)
- rename structured bindings shadowed by inner declarations (cpp:S1117)
This commit is contained in:
jerrrrycho
2026-10-11 01:41:01 +02:00
parent 555e5f0aab
commit 2b74c6dba7
17 changed files with 37 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
McZapkie/Mover.cpp
View File

@@ -4295,7 +4295,7 @@ void TMoverParameters::CompressorCheck(double dt)
EmergencyValveOpen = Compressor > (EmergencyValveOpen ? EmergencyValveOff : EmergencyValveOn);
if (EmergencyValveOpen)
{
float dV = static_cast<float>(PF(0, Compressor, EmergencyValveArea) * dt);
auto dV = static_cast<float>(PF(0, Compressor, EmergencyValveArea) * dt);
CompressedVolume -= dV;
}
@@ -4578,7 +4578,7 @@ void TMoverParameters::UpdatePipePressure(double dt)
{
LocBrakePress = LocHandle->GetCP();
for (auto &couplerentry : Couplers)
for (auto const &couplerentry : Couplers)
// nie podoba mi się to rozwiązanie, chyba trzeba
// dodać jakiś wpis do fizyki na to
if ((TrainType & (dt_ET41 | dt_ET42)) != 0 && couplerentry.Connected != nullptr && (couplerentry.Connected->TrainType & (dt_ET41 | dt_ET42)) != 0 && (couplerentry.CouplingFlag & 36) == 36)
@@ -6246,7 +6246,7 @@ double TMoverParameters::TractionForce(double dt)
SpeedCtrlTimer += dt;
if (SpeedCtrlTimer > SpeedCtrlDelay)
{
int NewSCAP = static_cast<int>((float)ScndCtrlPos / (float)ScndCtrlPosNo * Vmax);
auto NewSCAP = static_cast<int>((float)ScndCtrlPos / (float)ScndCtrlPosNo * Vmax);
if (NewSCAP != SpeedCtrlValue)
{
SpeedCtrlValue = NewSCAP;
@@ -7945,7 +7945,6 @@ double TMoverParameters::dizel_Momentum(double Fill, double n, double dt)
double eps = 0;
double newn = 0;
double friction = 0;
double neps = 0;
double TorqueH = 0;
double TorqueL = 0;
double TorqueC = 0;
@@ -12472,9 +12471,8 @@ bool TMoverParameters::RunCommand(std::string const &Command, double CValue1, do
{
auto const leftside{CValue2 > 0 ? 1 : 2};
auto const rightside{3 - leftside};
if (static_cast<int>(CValue1) & rightside)
if (auto const rightside{3 - leftside}; static_cast<int>(CValue1) & rightside)
{
Doors.instances[side::right].remote_open = true;
Doors.instances[side::right].remote_close = false;
@@ -12494,9 +12492,8 @@ bool TMoverParameters::RunCommand(std::string const &Command, double CValue1, do
{
auto const leftside{CValue2 > 0 ? 1 : 2};
auto const rightside{3 - leftside};
if (static_cast<int>(CValue1) & rightside)
if (auto const rightside{3 - leftside}; static_cast<int>(CValue1) & rightside)
{
Doors.instances[side::right].remote_close = true;
Doors.instances[side::right].remote_open = false;