eu07/maszyna
17
0
Fork 0
mirror of https://github.com/MaSzyna-EU07/maszyna.git synced 2026-10-17 01:39:20 +02:00
Code Issues 150 Wiki Activity

perf(scenery): node or event added to a group without searching the whole group for a duplicate, unless it already was a member of it

Browse Source
This commit is contained in:
Hirek
2026-10-06 03:34:19 +02:00
parent 7dd5005574
commit 4eb14a9419
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
scene/scenenodegroups.cpp
View File

@@ -239,12 +239,16 @@ void
node_groups::insert( scene::group_handle const Group, scene::basic_node *Node ) {
// TBD, TODO: automatically unregister the node from its current group?
auto const previousgroup { Node->group() };
Node->group( Group );
if( Group == null_handle ) { return; }
auto &nodesequence { m_groupmap[ Group ].nodes };
if( std::find( std::begin( nodesequence ), std::end( nodesequence ), Node ) == std::end( nodesequence ) ) {
// a node which wasn't a member of the group can't be on its list, which saves the search through the list.
// it matters as a group can be large, the root group of a scenery holds nearly all its nodes
if( previousgroup != Group
|| std::find( std::begin( nodesequence ), std::end( nodesequence ), Node ) == std::end( nodesequence ) ) {
// don't add the same node twice
nodesequence.emplace_back( Node );
}
@@ -255,12 +259,15 @@ void
node_groups::insert( scene::group_handle const Group, basic_event *Event ) {
// TBD, TODO: automatically unregister the event from its current group?
auto const previousgroup { Event->group() };
Event->group( Group );
if( Group == null_handle ) { return; }
auto &eventsequence { m_groupmap[ Group ].events };
if( std::find( std::begin( eventsequence ), std::end( eventsequence ), Event ) == std::end( eventsequence ) ) {
// same as with the nodes, the list is searched only for an event which already was a member of the group
if( previousgroup != Group
|| std::find( std::begin( eventsequence ), std::end( eventsequence ), Event ) == std::end( eventsequence ) ) {
// don't add the same node twice
eventsequence.emplace_back( Event );
}