17
0
mirror of https://github.com/MaSzyna-EU07/maszyna.git synced 2026-11-13 00:34:30 +01:00

refactor: the Sonar remarks on the small fixes taken care of

- the log stops through a flag kept in a function, not a global one
- the messages are put together with std::format
- a vehicle dropped on a trainset in the launcher goes in once the
  trainset is drawn, so the vehicles are gone through with a plain loop
  again; the drop split into a new vehicle and a moved one
- the scenario that can't be opened is caught as the runtime error it
  is, a file name outside of the code page as the system error it is
- a track of an unknown type is left out through the pointer owning it
- the keyword of a track type written out by a function of its own
- the picked node forgotten with ranges::replace_if, the empty
  Forget_Node of the base renderer told why it is empty
- FileCased takes the path it works on
This commit is contained in:
maj00r
2026-11-06 19:54:54 +01:00
parent 8523316006
commit a6778c9fe2
14 changed files with 140 additions and 75 deletions

View File

@@ -54,6 +54,8 @@ private:
scenery_desc *selected_scenery = nullptr;
trainset_desc *selected_trainset = nullptr;
deferred_image placeholder_mini;
// a vehicle dropped on a gap between the vehicles of a trainset: put in there once they're all drawn, not while they are
std::function<void()> m_drop;
void draw_scenery_list();
void draw_scenery_info();
@@ -67,6 +69,8 @@ private:
void open_link(const std::string &link);
void draw_trainset(trainset_desc &trainset);
void draw_droptarget(trainset_desc &trainset, int position);
void drop_new_vehicle(trainset_desc &trainset, int position, skin_set const *Skin);
void drop_moved_vehicle(trainset_desc &trainset, int position, vehicle_moved const &Moved);
void purge_selected_trainset();
};
} // namespace ui