Merge branch 'milek-dev' into gfx-work

Button.cpp

@@ -71,7 +71,7 @@ void TButton::Load( cParser &Parser, TDynamicObject const *Owner, TModel3d *pMod
     if( ( pModelOn  == nullptr )
      && ( pModelOff == nullptr ) ) {
         // if we failed to locate even one state submodel, cry
-        ErrorLog( "Bad model: failed to locate sub-model \"" + submodelname + "\" in 3d model \"" + pModel1->NameGet() + "\"", logtype::model );
+        ErrorLog( "Bad model: failed to locate sub-model \"" + submodelname + "\" in 3d model \"" + ( pModel1 != nullptr ? pModel1->NameGet() : pModel2 != nullptr ? pModel2->NameGet() : "NULL" ) + "\"", logtype::model );
     }
 
     // pass submodel location to defined sounds

PyInt.cpp

@@ -44,14 +44,20 @@ void render_task::run() {
 
             glFlush();
         }
-        Py_DECREF( outputheight );
-        Py_DECREF( outputwidth );
+        if( outputheight != nullptr ) { Py_DECREF( outputheight ); }
+        if( outputwidth  != nullptr ) { Py_DECREF( outputwidth ); }
         Py_DECREF( output );
     }
     // clean up after yourself
     delete this;
 }
 
+void render_task::cancel() {
+
+    Py_DECREF( m_input );
+    delete this;
+}
+
 // initializes the module. returns true on success
 auto python_taskqueue::init() -> bool {
 
@@ -142,7 +148,7 @@ void python_taskqueue::exit() {
     // get rid of the leftover tasks
     // with the workers dead we don't have to worry about concurrent access anymore
     for( auto *task : m_tasks.data ) {
-        delete task;
+        task->cancel();
     }
     // take a bow
     PyEval_AcquireLock();
@@ -159,22 +165,29 @@ auto python_taskqueue::insert( task_request const &Task ) -> bool {
 
     auto *renderer { fetch_renderer( Task.renderer ) };
     if( renderer == nullptr ) { return false; }
-    // acquire a lock on the task queue and add a new task
+
+    auto *newtask { new render_task( renderer, Task.input, Task.target ) };
+    bool newtaskinserted { false };
+    // acquire a lock on the task queue and add the new task
     {
         std::lock_guard<std::mutex> lock( m_tasks.mutex );
-
-        // if task for this target already exists, don't add another
-        for (render_task *task : m_tasks.data)
-            if (task->get_target() == Task.target)
-            {
+        // check the task list for a pending request with the same target
+        for( auto &task : m_tasks.data ) {
+            if( task->target() == Task.target ) {
+                // replace pending task in the slot with the more recent one
                 PyEval_AcquireLock();
-                Py_DECREF(Task.input);
+                {
+                    task->cancel();
+                }
                 PyEval_ReleaseLock();
-
-                return false;
+                task = newtask;
+                newtaskinserted = true;
+                break;
             }
-
-        m_tasks.data.emplace_back( new render_task( renderer, Task.input, Task.target ) );
+        }
+        if( false == newtaskinserted ) {
+            m_tasks.data.emplace_back( newtask );
+        }
     }
     // potentially wake a worker to handle the new task
     m_condition.notify_one();

PyInt.h

@@ -44,7 +44,8 @@ public:
     {}
 // methods
     void run();
-    const texture_handle get_target() const { return m_target; }
+    void cancel();
+    auto target() const -> texture_handle { return m_target; }
 
 private:
 // members

Track.cpp

@@ -1745,7 +1745,7 @@ int TTrack::CrossSegment(int from, int into)
 
 void TTrack::RaAnimListAdd(TTrack *t)
 { // dodanie toru do listy animacyjnej
-    if (SwitchExtension)
+    if ((t != nullptr) && (SwitchExtension != nullptr))
     {
         if (t == this)
             return; // siebie nie dodajemy drugi raz do listy

version.h

@@ -1 +1 @@
-#define VERSION_INFO "M7 (GL3) 14.10.2018, based on milek-8a8d92ef, tmj-68f82be4"
+#define VERSION_INFO "M7 (GL3) 14.10.2018, based on milek-87d95b2d, tmj-81c9238"