eu07/maszyna
17
0
Fork 0
mirror of https://github.com/MaSzyna-EU07/maszyna.git synced 2026-10-18 06:49:18 +02:00
Code Issues 151 Wiki Activity

Do not start a shut down engine on a signal; address SonarCloud findings

Browse Source 
A permitting signal no longer wakes a dormant AI: the synthetic departure
command, the shunt-signal ownership tag and the secondary scan that fed
them are gone, and cm_SetVelocity / cm_ShuntVelocity go back to plain
PutCommand with the pre-existing order mask. A secondary now only settles
its own vehicle. Claiming the lead stays for explicit orders.

The rest is SonarCloud cleanup on the branch: if-init statements, merged
and flattened conditionals, split chained assignments, ranges::any_of,
pointer-to-const parameters, std::array for the flag name table and no
more shadowed names.
This commit is contained in:
maj00r
2026-09-14 23:51:20 +02:00
parent a1e4e8d95b
commit e6c2d189ff
5 changed files with 91 additions and 213 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
simulation/simulationstateserializer.cpp
View File

@@ -852,8 +852,8 @@ TDynamicObject *select_trainset_driver( trainset_data &trainset )
if( vehicle->Mechanik == nullptr || !vehicle->Mechanik->primary() ) {
continue;
}
auto const lookup { trainset.assignment.find( Global.asLang ) };
if( lookup != trainset.assignment.end() ) {
if( auto const lookup { trainset.assignment.find( Global.asLang ) };
lookup != trainset.assignment.end() ) {
vehicle->Mechanik->assignment() = lookup->second;
}
return vehicle;