jerrrrycho
780ddf9ddb
refactor(sonar): more small fixes
...
- std::format instead of iostream manipulators in to_string/to_hex_str (cpp:S6495);
output verified identical, negative hex values keep the unsigned form
- remove an empty compound statement (cpp:S108)
- drop an always-false unsigned < 0 branch (cpp:S1768)
- explicit lambda capture (cpp:S3608)
- std::make_unique (cpp:S5950)
2026-10-10 20:44:56 +02:00
jerrrrycho
ba6840b6ba
refactor(sonar): assorted small fixes
...
- empty() instead of size() comparisons (cpp:S1155)
- member initialisers in declaration order (cpp:S3229)
- no redundant c_str() when a std::string is accepted (cpp:S7121)
- contains() on associative containers (cpp:S6171)
- const reference instead of a copying range-for (cpp:S6032)
- starts_with() for prefix checks (cpp:S6178)
- no std::move on temporaries (cpp:S5274)
- has_value() on std::optional (cpp:S7172)
- bool literals for bool members (cpp:S5820)
- inline only on the definition (cpp:S3548)
- explicit base access specifier (cpp:S5965)
- explicit element access instead of dereferencing an array (cpp:S7116)
- rely on the C++20 rewritten operator!= (cpp:S6186)
2026-10-10 20:44:56 +02:00
jerrrrycho
a322472632
refactor(sonar): use std::array for local fixed-size arrays (cpp:S5945)
...
Arrays that are class members or part of headers are left unchanged.
2026-10-10 20:44:55 +02:00
jerrrrycho
d846665b3b
refactor(sonar): replace single-case switch statements with if (cpp:S1301)
2026-10-10 20:44:54 +02:00
jerrrrycho
f6736fa233
refactor(sonar): pass expensive-to-copy parameters by const reference (cpp:S1238)
...
Signatures declared in files touched by PR 206 (Driver.h, EU07.cpp) and
virtual overrides are left unchanged.
2026-10-10 20:44:51 +02:00
jerrrrycho
693a817d5e
refactor(sonar): make read-only local references and pointers const (cpp:S5350)
2026-10-10 20:44:50 +02:00
jerrrrycho
29e8a1befc
refactor(sonar): initialise members in initialiser lists or declarations (cpp:S3230)
2026-10-10 20:44:50 +02:00
jerrrrycho
34c0c8182d
refactor(sonar): reduce enum qualification with using enum (cpp:S6177)
...
Applied only where no unqualified name in the block could be captured by
the introduced enumerators.
2026-10-10 20:44:49 +02:00
jerrrrycho
e524d38128
refactor(sonar): rename locals that shadow outer declarations (cpp:S1117)
...
Only local variables and definition parameters are renamed; shadowing
struct fields and enumerators in headers are left for a separate change.
2026-10-10 20:44:48 +02:00
jerrrrycho
f82b12b2c6
refactor(sonar): avoid side effects inside typeid operands (cpp:S5279)
2026-10-10 20:44:45 +02:00
jerrrrycho
a510996dc7
refactor(sonar): add braces around nested if-else (cpp:S5261)
2026-10-10 20:44:45 +02:00
jerrrrycho
d0a6353449
refactor(sonar): use std::ranges algorithms and std::erase(_if) (cpp:S6197)
2026-10-10 20:44:44 +02:00
jerrrrycho
eb82bf360b
refactor(sonar): add default cases to switch statements (cpp:S3562)
2026-10-10 20:44:43 +02:00
jerrrrycho
6b77352293
refactor(sonar): split chained assignments (cpp:S1121)
2026-10-10 20:44:43 +02:00
jerrrrycho
2d1cac601e
refactor(sonar): use range-based loops and ranges algorithms (cpp:S5566)
2026-10-10 20:44:42 +02:00
jerrrrycho
560512bd9e
refactor(sonar): use structured bindings for pair access (cpp:S6005)
2026-10-10 20:44:42 +02:00
jerrrrycho
71b338f30e
refactor(sonar): remove unused variables, captures and private fields (cpp:S1481, cpp:S1068)
2026-10-10 20:44:41 +02:00
jerrrrycho
d28695f073
refactor(sonar): remove dead stores (cpp:S1854)
...
Side effects (e.g. LISTLINE++) are kept.
2026-10-10 20:44:41 +02:00
jerrrrycho
9aa7e658ac
refactor(sonar): remove redundant parentheses (cpp:S1110)
2026-10-10 20:44:40 +02:00
jerrrrycho
f8c6e358bd
refactor(sonar): use try_emplace for map insertion (cpp:S6030)
2026-10-10 20:44:39 +02:00
jerrrrycho
6fce71af36
refactor(sonar): scope single-use variables in if init-statements (cpp:S6004)
2026-10-10 20:44:38 +02:00
jerrrrycho
0d886e65ec
refactor(sonar): merge collapsible nested if statements (cpp:S1066)
...
Comments that preceded the inner if are kept above the merged statement.
2026-10-10 20:44:37 +02:00
jerrrrycho
8042953b95
refactor(sonar): declare non-mutating member functions const (cpp:S5817)
...
Virtual functions are left untouched so overrides keep matching.
2026-10-10 20:44:37 +02:00
jerrrrycho
01d2b9bf82
refactor(sonar): mark unused parameters (cpp:S1172)
...
Unused names are commented out; parameters used only on some platforms
are marked [[maybe_unused]].
2026-10-10 20:44:36 +02:00
jerrrrycho
ad32f1f840
refactor(sonar): make narrowing conversions explicit (cpp:S5276)
2026-10-10 20:44:35 +02:00
jerrrrycho
07d94806b7
refactor(sonar): remove redundant casts (cpp:S1905)
2026-10-10 20:44:34 +02:00
jerrrrycho
baafdcc1cc
refactor(sonar): use =default for trivial special members (cpp:S3490)
2026-10-10 20:44:32 +02:00
jerrrrycho
c4738dbc87
refactor(sonar): remove empty statements, one declaration per statement (cpp:S1116, cpp:S1659)
2026-10-10 20:44:31 +02:00
jerrrrycho
79bd0c8e91
fix(sonar): addressing reliability/security issues ( #202 )
2026-10-04 20:00:13 +02:00
Ryba04
763a76d48c
Expose dynamic brake controller position to python script dictionary
2026-08-19 00:55:24 +02:00
jakubg1
1929119db6
Simplify lamp logic, add new lights for 810 vehicles ( #148 )
...
Simplified lamp logic by reducing unnecessary brackets, `if` statements, ternary operators and boolean comparisons.
Added new lamps:
- `i-gear1` - 1st gear in the gearbox is active
- `i-gear2` - 2nd gear in the gearbox is active
- `i-hydrolockup` - The gearbox is locking the engine and wheels together
Additionally, fixed motor overload and differential relay lights not turning off when the battery is turned off.
2026-07-21 22:44:04 +02:00
jerrrrycho
d85096f64d
reformat: remove redundant parentheses
2026-06-30 21:19:46 +02:00
jerrrrycho
bf147dd155
refactor: replace null with nullptr
2026-06-29 02:48:25 +02:00
docentYT
4a67b4b2a9
Fix conflict
2026-05-05 23:32:59 +02:00
cb4b6b9a4f
Separate electrodynamic and localbrake levers
2026-05-03 21:51:16 +02:00
7acc34df3e
Merge pull request #97 from docentYT/migrate-from-dumb3d-to-glm
...
Migrate from dumb3d to glm
2026-04-28 19:46:46 +02:00
docentYT
ca839652bf
Use the sq function to force constexpr expressions for numeric literals and enhance readability
2026-04-28 13:23:14 +02:00
docentYT
d5d1825e38
Remove dumb3d
2026-04-27 23:03:47 +02:00
docentYT
0fcdf98392
more glm instead of Math3D in vehicle
2026-04-27 21:57:13 +02:00
docentYT
ef852b4307
Fix model rotation by changing glm::dmat4 BasisChange definition
2026-04-27 21:28:06 +02:00
docentYT
fae68642bc
use glm instead of Math3D in vehicle
...
WARNING: Model rotation is broken
2026-04-27 13:07:38 +02:00
6177cfb01d
Add radiocall1
2026-04-19 04:15:25 +02:00
Agent
68fa78a582
feat(overheat): Add overheat indicator lamps for oil, water, water_aux, and engine
...
- Add engine_max_temp and engine_is_hot fields to heat_data structure
- Add EngineMaxTemperature field extraction from .fiz files
- Add engine overheat check comparing Ts with engine_max_temp
- Add four new overheat lamp indicators:
- i-oil_overheat
- i-water_overheat
- i-wateraux_overheat
- i-engine_overheat
- Add lamp update logic to turn on/off based on is_hot flags
- Add lamp initialization in clear_cab_controls()
This implements issue #77 - overheat lamps for diesel engines.
The lamps will turn on when:
- Oil temperature exceeds OilMaxTemperature
- Water temperature exceeds WaterMaxTemperature
- Auxiliary water temperature exceeds WaterAuxMaxTemperature
- Engine temperature exceeds EngineMaxTemperature
Each check includes 8-degree hysteresis to prevent rapid on/off cycling.
2026-04-01 23:26:39 +00:00
jerrrrycho
9f43dca48b
refactor: create paths namespace instead of global variables
2026-03-15 11:55:30 +01:00
copilot-swe-agent[bot]
7e49aa8740
Rewrite #includes to use explicit subdirectory paths
...
Co-authored-by: Hirek193 <23196899+Hirek193@users.noreply.github.com >
2026-03-14 19:16:48 +00:00
copilot-swe-agent[bot]
0531086bb9
Reorganize source files into logical subdirectories
...
Co-authored-by: Hirek193 <23196899+Hirek193@users.noreply.github.com >
2026-03-14 19:01:57 +00:00