eu07/maszyna
17
0
Fork 0
mirror of https://github.com/MaSzyna-EU07/maszyna.git synced 2026-10-17 02:49:19 +02:00
Code Issues 150 Wiki Activity
3,187 Commits 78 Branches 30 Tags
fix/sonar-maintainability
Commit Graph

59 Commits

Author SHA1 Message Date
jerrrrycho
b6186ced21 refactor(sonar): assorted small fixes 
- empty() instead of size() comparisons (cpp:S1155)
- member initialisers in declaration order (cpp:S3229)
- no redundant c_str() when a std::string is accepted (cpp:S7121)
- contains() on associative containers (cpp:S6171)
- const reference instead of a copying range-for (cpp:S6032)
- starts_with() for prefix checks (cpp:S6178)
- no std::move on temporaries (cpp:S5274)
- has_value() on std::optional (cpp:S7172)
- bool literals for bool members (cpp:S5820)
- inline only on the definition (cpp:S3548)
- explicit base access specifier (cpp:S5965)
- explicit element access instead of dereferencing an array (cpp:S7116)
- rely on the C++20 rewritten operator!= (cpp:S6186)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 17:50:12 +02:00
jerrrrycho
1be2d2e682 refactor(sonar): use std::bind_front for callbacks (cpp:S5995) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 17:24:04 +02:00
jerrrrycho
5d33d89225 refactor(sonar): pass expensive-to-copy parameters by const reference (cpp:S1238) 
Signatures declared in files touched by PR 206 (Driver.h, EU07.cpp) and
virtual overrides are left unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 17:16:40 +02:00
jerrrrycho
3a6f21eb2d refactor(sonar): initialise members in initialiser lists or declarations (cpp:S3230) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 17:03:17 +02:00
jerrrrycho
1cc9890197 refactor(sonar): mark converting constructors explicit (cpp:S1709) 
sound_source and the gl::object conversion operators stay implicit; they
are relied upon by copy-list-initialisation and GL calls.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 16:55:10 +02:00
jerrrrycho
a47c2a6ea0 refactor(sonar): rename locals that shadow outer declarations (cpp:S1117) 
Only local variables and definition parameters are renamed; shadowing
struct fields and enumerators in headers are left for a separate change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 16:45:39 +02:00
jerrrrycho
427e2823e9 refactor(sonar): inherit base constructors instead of forwarding them (cpp:S5952) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 16:41:22 +02:00
jerrrrycho
b6349b76e3 refactor(sonar): use structured bindings for pair access (cpp:S6005) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 16:06:32 +02:00
jerrrrycho
5a806223e7 refactor(sonar): document intentionally empty functions (cpp:S1186) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 15:56:34 +02:00
jerrrrycho
8f89dcefcd refactor(sonar): use auto where the type is spelled out on the right (cpp:S5827) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 15:52:25 +02:00
jerrrrycho
95bc9bd511 refactor(sonar): use try_emplace for map insertion (cpp:S6030) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 15:51:29 +02:00
jerrrrycho
6547f7e967 fix(sonar): give polymorphic base classes virtual destructors (cpp:S1235) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 15:48:07 +02:00
jerrrrycho
9b89a5d887 refactor(sonar): scope single-use variables in if init-statements (cpp:S6004) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 15:44:18 +02:00
jerrrrycho
3198cabc78 refactor(sonar): declare non-mutating member functions const (cpp:S5817) 
Virtual functions are left untouched so overrides keep matching.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 15:26:48 +02:00
jerrrrycho
1f256e9593 refactor(sonar): mark unused parameters (cpp:S1172) 
Unused names are commented out; parameters used only on some platforms
are marked [[maybe_unused]].

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 15:18:45 +02:00
jerrrrycho
8c23c1fe2b refactor(sonar): make narrowing conversions explicit (cpp:S5276) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 15:16:28 +02:00
jerrrrycho
7b3109061e refactor(sonar): use =default for trivial special members (cpp:S3490) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 15:05:45 +02:00
jerrrrycho
8ce68e3d41 refactor(sonar): use override instead of redundant virtual (cpp:S3471) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 14:55:56 +02:00
jerrrrycho
79bd0c8e91 fix(sonar): addressing reliability/security issues (#202) 2026-10-04 20:00:13 +02:00
jerrrrycho
176427f96b refactor: sonar c++20 changes (#185) 2026-09-28 21:08:15 +02:00
docentYT
2bb8a64877 Specify auto as reference where possible 2026-05-12 19:16:33 +02:00
copilot-swe-agent[bot]
7e49aa8740 Rewrite #includes to use explicit subdirectory paths 
Co-authored-by: Hirek193 <23196899+Hirek193@users.noreply.github.com>
 2026-03-14 19:16:48 +00:00
jakubg1
22c0aed82d Change asio::ip::address::from_string() to asio::ip::make_address() 
The former function has been removed from Boost recently.
 2025-09-09 15:51:33 +02:00
milek7
ca8145904b do not make unnecessary exports on nix platforms 2021-01-30 16:00:58 +01:00
milek7
29f8f91ad8 Merge remote-tracking branch 'tmj/master' into sim 2020-10-18 23:35:14 +02:00
milek7
936effa9db openvr WIP 2020-09-29 22:27:13 +02:00
tmj-fstate
330bd3c455 post-merge fixes 2020-02-20 20:28:32 +01:00
tmj-fstate
7a0c89f508 milek7/sim branch network code import 2020-02-16 03:03:17 +01:00
milek7
a16cf6cdab desync info tweaks 2019-11-17 15:21:02 +01:00
milek7
5c84f8b156 remove DBG_NEW new preprocessor kludges, ensure stdafx.h is included everywhere, add debug build to Azure CI 2019-08-30 23:35:58 +02:00
milek7
5160073282 fixup dynobj placement, tune network 2019-04-03 01:46:31 +02:00
milek7
4344ec192a network changes 2019-04-03 01:28:46 +02:00
milek7
155217243c gui changes, consist teleport command, etc 2019-04-02 20:42:18 +02:00
milek7
e3c88b9834 network-aware obstacles, other changes 2019-03-16 17:13:46 +01:00
milek7
3693c1660e renderer changes, time and environment window 2019-03-09 21:14:01 +01:00
milek7
52ff1ecb98 display train names on map 2019-02-18 00:07:09 +01:00
milek7
d391851c66 network improvements 2019-02-13 21:41:10 +01:00
milek7
75a9db413f tweak packet sizes 2019-02-06 00:16:45 +01:00
milek7
6962e25042 network improvements and fixes 2019-02-06 00:03:48 +01:00
milek7
85ad17af3c network fixes and improvements, code refactoring 2019-02-03 23:24:34 +01:00
milek7
ec34720ad6 work 2019-01-29 23:19:32 +01:00
milek7
cf6cbe9a8e work 2019-01-29 19:02:16 +01:00
milek7
672e3e022a work 2019-01-28 23:19:41 +01:00
milek7
d5760c9e9c work 2019-01-28 00:34:36 +01:00
milek7
90f18ea651 work 2019-01-27 20:38:03 +01:00
milek7
1ef74838ee work 2019-01-20 15:32:03 +01:00
milek7
1314f09c4d work 2019-01-18 00:36:41 +01:00
milek7
f63bd04bfe work 2019-01-18 00:26:48 +01:00
milek7
f55a5465ef work 2019-01-14 22:45:22 +01:00
milek7
b2a9388fab work 2019-01-14 00:20:14 +01:00