eu07/maszyna
17
0
Fork 0
mirror of https://github.com/MaSzyna-EU07/maszyna.git synced 2026-10-17 01:39:20 +02:00
Code Issues 150 Wiki Activity
3,187 Commits 78 Branches 30 Tags
fix/sonar-maintainability
Commit Graph

3187 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
jerrrrycho
c82cc0d4a4 refactor(sonar): more small fixes 
- std::format instead of iostream manipulators in to_string/to_hex_str (cpp:S6495);
  output verified identical, negative hex values keep the unsigned form
- remove an empty compound statement (cpp:S108)
- drop an always-false unsigned < 0 branch (cpp:S1768)
- explicit lambda capture (cpp:S3608)
- std::make_unique (cpp:S5950)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 17:52:59 +02:00
jerrrrycho
b6186ced21 refactor(sonar): assorted small fixes 
- empty() instead of size() comparisons (cpp:S1155)
- member initialisers in declaration order (cpp:S3229)
- no redundant c_str() when a std::string is accepted (cpp:S7121)
- contains() on associative containers (cpp:S6171)
- const reference instead of a copying range-for (cpp:S6032)
- starts_with() for prefix checks (cpp:S6178)
- no std::move on temporaries (cpp:S5274)
- has_value() on std::optional (cpp:S7172)
- bool literals for bool members (cpp:S5820)
- inline only on the definition (cpp:S3548)
- explicit base access specifier (cpp:S5965)
- explicit element access instead of dereferencing an array (cpp:S7116)
- rely on the C++20 rewritten operator!= (cpp:S6186)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 17:50:12 +02:00
jerrrrycho
2e92076e21 fix(sonar): test the bearing damage bit, not bit 0 (cpp:S872) 
'DamageFlag & dtrain_bearing > 0' parsed as 'DamageFlag & (dtrain_bearing > 0)',
i.e. DamageFlag & 1, so bearing friction reacted to the wrong damage flag.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 17:46:06 +02:00
jerrrrycho
43fcda05a0 refactor(sonar): use std::array for local fixed-size arrays (cpp:S5945) 
Arrays that are class members or part of headers are left unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 17:44:14 +02:00
jerrrrycho
312ba58ffa refactor(sonar): format UUIDs and log timestamps with std::format (cpp:S6494, cpp:S5945) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 17:44:12 +02:00
jerrrrycho
9fec0e925c refactor(sonar): replace single-case switch statements with if (cpp:S1301) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 17:39:27 +02:00
jerrrrycho
71d4796649 refactor(sonar): make read-only global tables const (cpp:S5421) 
Mutable global state (flags, timers, singletons) is left as is.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 17:36:32 +02:00
jerrrrycho
adfad8016e refactor(sonar): take read-only string parameters as std::string_view (cpp:S6009) 
The Windows messaging helpers keep std::string, they need c_str().

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 17:28:41 +02:00
jerrrrycho
ec8a333753 refactor(sonar): drop const_cast on string literals passed to the Python C API (cpp:S859) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 17:24:04 +02:00
jerrrrycho
1be2d2e682 refactor(sonar): use std::bind_front for callbacks (cpp:S5995) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 17:24:04 +02:00
jerrrrycho
033fc83aac fix(sonar): do not use UI text as a printf format string (cpp:S5281) 
Text lines containing '%' would otherwise be interpreted as format
specifiers by ImGui::TextColored.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 17:24:04 +02:00
jerrrrycho
2ba33e8e63 refactor(sonar): use transparent comparators for string-keyed maps (cpp:S6045) 
std::unordered_map instances and map types exposed in headers used by
other modules are left as they are.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 17:21:07 +02:00
jerrrrycho
5d33d89225 refactor(sonar): pass expensive-to-copy parameters by const reference (cpp:S1238) 
Signatures declared in files touched by PR 206 (Driver.h, EU07.cpp) and
virtual overrides are left unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 17:16:40 +02:00
jerrrrycho
0a7c42c4a9 refactor(sonar): take read-only pointer and reference parameters as const (cpp:S995) 
TTrain command handlers keep their signature, it is fixed by the handler table.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 17:08:45 +02:00
jerrrrycho
d7edea6fac refactor(sonar): make read-only local references and pointers const (cpp:S5350) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 17:05:09 +02:00
jerrrrycho
3a6f21eb2d refactor(sonar): initialise members in initialiser lists or declarations (cpp:S3230) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 17:03:17 +02:00
jerrrrycho
1cc9890197 refactor(sonar): mark converting constructors explicit (cpp:S1709) 
sound_source and the gl::object conversion operators stay implicit; they
are relied upon by copy-list-initialisation and GL calls.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 16:55:10 +02:00
jerrrrycho
8afb232f2a refactor(sonar): reduce enum qualification with using enum (cpp:S6177) 
Applied only where no unqualified name in the block could be captured by
the introduced enumerators.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 16:49:01 +02:00
jerrrrycho
a47c2a6ea0 refactor(sonar): rename locals that shadow outer declarations (cpp:S1117) 
Only local variables and definition parameters are renamed; shadowing
struct fields and enumerators in headers are left for a separate change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 16:45:39 +02:00
jerrrrycho
427e2823e9 refactor(sonar): inherit base constructors instead of forwarding them (cpp:S5952) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 16:41:22 +02:00
jerrrrycho
7c0f81fb30 refactor(sonar): rely on class template argument deduction (cpp:S6012) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 16:37:55 +02:00
jerrrrycho
89583b2569 refactor(sonar): declare loop counters in the for statement (cpp:S5955) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 16:34:28 +02:00
jerrrrycho
f19e64bc11 refactor(sonar): declare variables separately from their type definitions (cpp:S3646) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 16:33:12 +02:00
jerrrrycho
319815cb0b refactor(sonar): drop top-level const from by-value return types (cpp:S5951) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 16:29:47 +02:00
jerrrrycho
85640589aa refactor(sonar): avoid side effects inside typeid operands (cpp:S5279) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 16:26:40 +02:00
jerrrrycho
0bf013fef9 refactor(sonar): add braces around nested if-else (cpp:S5261) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 16:25:40 +02:00
jerrrrycho
24425d222f refactor(sonar): access static members through the class (cpp:S2209) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 16:24:59 +02:00
jerrrrycho
51337cb1b7 refactor(sonar): use std::ranges algorithms and std::erase(_if) (cpp:S6197) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 16:24:06 +02:00
jerrrrycho
22c7c33a63 refactor(sonar): use std::size for array lengths (cpp:S7127) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 16:22:49 +02:00
jerrrrycho
6445ef728a refactor(sonar): add default cases to switch statements (cpp:S3562) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 16:22:01 +02:00
jerrrrycho
c67b8be22e refactor(sonar): split chained assignments (cpp:S1121) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 16:20:06 +02:00
jerrrrycho
03652a5934 refactor(sonar): use range-based loops and ranges algorithms (cpp:S5566) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 16:13:12 +02:00
jerrrrycho
b6349b76e3 refactor(sonar): use structured bindings for pair access (cpp:S6005) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 16:06:32 +02:00
jerrrrycho
9c7043d013 refactor(sonar): remove unused variables, captures and private fields (cpp:S1481, cpp:S1068) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 16:03:19 +02:00
jerrrrycho
ce786c22ce refactor(sonar): remove dead stores (cpp:S1854) 
Side effects (e.g. LISTLINE++) are kept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 15:58:05 +02:00
jerrrrycho
5a806223e7 refactor(sonar): document intentionally empty functions (cpp:S1186) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 15:56:34 +02:00
jerrrrycho
41e802eb7a refactor(sonar): remove redundant parentheses (cpp:S1110) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 15:55:46 +02:00
jerrrrycho
8f89dcefcd refactor(sonar): use auto where the type is spelled out on the right (cpp:S5827) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 15:52:25 +02:00
jerrrrycho
95bc9bd511 refactor(sonar): use try_emplace for map insertion (cpp:S6030) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 15:51:29 +02:00
jerrrrycho
6547f7e967 fix(sonar): give polymorphic base classes virtual destructors (cpp:S1235) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 15:48:07 +02:00
jerrrrycho
9b89a5d887 refactor(sonar): scope single-use variables in if init-statements (cpp:S6004) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 15:44:18 +02:00
jerrrrycho
f8104bd0dd refactor(sonar): merge collapsible nested if statements (cpp:S1066) 
Comments that preceded the inner if are kept above the merged statement.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 15:39:11 +02:00
jerrrrycho
3198cabc78 refactor(sonar): declare non-mutating member functions const (cpp:S5817) 
Virtual functions are left untouched so overrides keep matching.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 15:26:48 +02:00
jerrrrycho
1f256e9593 refactor(sonar): mark unused parameters (cpp:S1172) 
Unused names are commented out; parameters used only on some platforms
are marked [[maybe_unused]].

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 15:18:45 +02:00
jerrrrycho
8c23c1fe2b refactor(sonar): make narrowing conversions explicit (cpp:S5276) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 15:16:28 +02:00
jerrrrycho
80464d0bc1 refactor(sonar): construct elements in place with emplace_back (cpp:S6003) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 15:06:57 +02:00
jerrrrycho
789e391420 refactor(sonar): use std::scoped_lock instead of std::lock_guard (cpp:S5997) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 15:06:48 +02:00
jerrrrycho
7e8081d904 refactor(sonar): remove redundant casts (cpp:S1905) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 15:06:37 +02:00
jerrrrycho
c831bb543c refactor(sonar): remove redundant access specifiers (cpp:S3539) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 15:05:48 +02:00
jerrrrycho
1806f029cc refactor(sonar): use nullptr literal (cpp:S4962) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-10 15:05:47 +02:00