eu07/maszyna
17
0
Fork 0
mirror of https://github.com/MaSzyna-EU07/maszyna.git synced 2026-10-17 03:59:19 +02:00
Code Issues 150 Wiki Activity
3,375 Commits 78 Branches 30 Tags
fix/sonar-maintainability-rebased
Commit Graph

39 Commits

Author SHA1 Message Date
jerrrrycho
2b74c6dba7 refactor(sonar): clean up issues reported on PR 209 
- remove locals left unused after the dead-store cleanup (cpp:S1481, cpp:S1854)
- unnamed unused parameter (cpp:S1172)
- single-use declarations moved into if init-statements (cpp:S6004)
- auto for casted initialisers (cpp:S5827)
- const references and pointers where nothing is modified (cpp:S5350)
- rename structured bindings shadowed by inner declarations (cpp:S1117)
 2026-10-11 01:41:01 +02:00
jerrrrycho
ba6840b6ba refactor(sonar): assorted small fixes 
- empty() instead of size() comparisons (cpp:S1155)
- member initialisers in declaration order (cpp:S3229)
- no redundant c_str() when a std::string is accepted (cpp:S7121)
- contains() on associative containers (cpp:S6171)
- const reference instead of a copying range-for (cpp:S6032)
- starts_with() for prefix checks (cpp:S6178)
- no std::move on temporaries (cpp:S5274)
- has_value() on std::optional (cpp:S7172)
- bool literals for bool members (cpp:S5820)
- inline only on the definition (cpp:S3548)
- explicit base access specifier (cpp:S5965)
- explicit element access instead of dereferencing an array (cpp:S7116)
- rely on the C++20 rewritten operator!= (cpp:S6186)
 2026-10-10 20:44:56 +02:00
jerrrrycho
7fc738fb58 refactor(sonar): make read-only global tables const (cpp:S5421) 
Mutable global state (flags, timers, singletons) is left as is.
 2026-10-10 20:44:54 +02:00
jerrrrycho
f6736fa233 refactor(sonar): pass expensive-to-copy parameters by const reference (cpp:S1238) 
Signatures declared in files touched by PR 206 (Driver.h, EU07.cpp) and
virtual overrides are left unchanged.
 2026-10-10 20:44:51 +02:00
jerrrrycho
4532d5e037 refactor(sonar): take read-only pointer and reference parameters as const (cpp:S995) 
TTrain command handlers keep their signature, it is fixed by the handler table.
 2026-10-10 20:44:51 +02:00
jerrrrycho
693a817d5e refactor(sonar): make read-only local references and pointers const (cpp:S5350) 2026-10-10 20:44:50 +02:00
jerrrrycho
34c0c8182d refactor(sonar): reduce enum qualification with using enum (cpp:S6177) 
Applied only where no unqualified name in the block could be captured by
the introduced enumerators.
 2026-10-10 20:44:49 +02:00
jerrrrycho
e524d38128 refactor(sonar): rename locals that shadow outer declarations (cpp:S1117) 
Only local variables and definition parameters are renamed; shadowing
struct fields and enumerators in headers are left for a separate change.
 2026-10-10 20:44:48 +02:00
jerrrrycho
3c80ea20c7 refactor(sonar): drop top-level const from by-value return types (cpp:S5951) 2026-10-10 20:44:46 +02:00
jerrrrycho
560512bd9e refactor(sonar): use structured bindings for pair access (cpp:S6005) 2026-10-10 20:44:42 +02:00
jerrrrycho
71b338f30e refactor(sonar): remove unused variables, captures and private fields (cpp:S1481, cpp:S1068) 2026-10-10 20:44:41 +02:00
jerrrrycho
d28695f073 refactor(sonar): remove dead stores (cpp:S1854) 
Side effects (e.g. LISTLINE++) are kept.
 2026-10-10 20:44:41 +02:00
jerrrrycho
413009e59e refactor(sonar): use auto where the type is spelled out on the right (cpp:S5827) 2026-10-10 20:44:39 +02:00
jerrrrycho
f8c6e358bd refactor(sonar): use try_emplace for map insertion (cpp:S6030) 2026-10-10 20:44:39 +02:00
jerrrrycho
6fce71af36 refactor(sonar): scope single-use variables in if init-statements (cpp:S6004) 2026-10-10 20:44:38 +02:00
jerrrrycho
0d886e65ec refactor(sonar): merge collapsible nested if statements (cpp:S1066) 
Comments that preceded the inner if are kept above the merged statement.
 2026-10-10 20:44:37 +02:00
jerrrrycho
8042953b95 refactor(sonar): declare non-mutating member functions const (cpp:S5817) 
Virtual functions are left untouched so overrides keep matching.
 2026-10-10 20:44:37 +02:00
jerrrrycho
01d2b9bf82 refactor(sonar): mark unused parameters (cpp:S1172) 
Unused names are commented out; parameters used only on some platforms
are marked [[maybe_unused]].
 2026-10-10 20:44:36 +02:00
jerrrrycho
ad32f1f840 refactor(sonar): make narrowing conversions explicit (cpp:S5276) 2026-10-10 20:44:35 +02:00
jerrrrycho
807d6822a5 refactor(sonar): remove redundant access specifiers (cpp:S3539) 2026-10-10 20:44:33 +02:00
jerrrrycho
9657955e62 refactor(sonar): use nullptr literal (cpp:S4962) 2026-10-10 20:44:33 +02:00
jerrrrycho
3f1c9720fb refactor(sonar): prefer using over typedef (cpp:S5416) 2026-10-10 20:44:32 +02:00
jerrrrycho
c4738dbc87 refactor(sonar): remove empty statements, one declaration per statement (cpp:S1116, cpp:S1659) 2026-10-10 20:44:31 +02:00
jerrrrycho
3d46090e49 refactor(sonar): use override instead of redundant virtual (cpp:S3471) 2026-10-10 20:44:30 +02:00
Hirek193
d60841944d Merge pull request #124 from xwizard/refactor/user-config-path 
refactor: extract user_config_path() helper
 2026-06-30 22:35:53 +02:00
Mateusz Włodarczyk
fe603f15eb refactor: extract user_config_path() helper 
Consolidates platform-specific config-directory logic (APPDATA on Windows,
~/Library/Application Support on macOS, ~/.config on Linux) into a single
user_config_path(filename) function in utilities/utilities.{cpp,h}, removing
copy-pasted #ifdef blocks from application.cpp, editor/editorSettings.cpp,
input/{keyboard,gamepad,drivermouse,uart}input.cpp.
 2026-06-30 21:30:36 +02:00
jerrrrycho
d85096f64d reformat: remove redundant parentheses 2026-06-30 21:19:46 +02:00
Sebastian Krzyszkowiak
6435c3d850 Remember which modifiers were present on key press and use them on key release 
This fixes an issue where a triggered command stays indefinitely active
when the user releases the modifier before releasing the triggering key.
 2026-06-29 23:21:21 +02:00
Daniu
5a39ed5193 ImGuizmo System OpenGL 2026-06-17 01:19:59 +02:00
Daniu
3bed2212d7 Editor settings for New/Legacy camera controll 2026-06-16 23:53:01 +02:00
docentYT
5367cb9940 Merge remote-tracking branch 'upstream/master' into utilities-simplification 2026-05-05 23:08:43 +02:00
Hirek193
cb4b6b9a4f Separate electrodynamic and localbrake levers 2026-05-03 21:51:16 +02:00
docentYT
13c7317f6e Do not allow implicit cast for inline std::string to_string(bool Value) and change to_string to std::string for non boolean values 2026-05-03 15:49:29 +02:00
docentYT
ca699d117f Remove not needed includes 2026-05-02 14:40:31 +02:00
docentYT
3628eb0fc3 Replace interpolate with std::lerp and glm::mix 2026-05-02 01:31:38 +02:00
docentYT
d1f16411a1 Replace clamp with std::clamp 2026-05-01 22:14:29 +02:00
Hirek193
6177cfb01d Add radiocall1 2026-04-19 04:15:25 +02:00
copilot-swe-agent[bot]
7e49aa8740 Rewrite #includes to use explicit subdirectory paths 
Co-authored-by: Hirek193 <23196899+Hirek193@users.noreply.github.com>
 2026-03-14 19:16:48 +00:00
copilot-swe-agent[bot]
0531086bb9 Reorganize source files into logical subdirectories 
Co-authored-by: Hirek193 <23196899+Hirek193@users.noreply.github.com>
 2026-03-14 19:01:57 +00:00